Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 522873005: Move MakeDivByTextureWHMatrix to GrCoordTransform (Closed)

Created:
6 years, 3 months ago by bsalomon
Modified:
6 years, 3 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Move MakeDivByTextureWHMatrix to GrCoordTransform Committed: https://skia.googlesource.com/skia/+/6267f81f3d60ce144ab2b09ea369420984d5c9d9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -21 lines) Patch
M include/gpu/GrCoordTransform.h View 2 chunks +10 lines, -1 line 0 comments Download
M include/gpu/GrEffect.h View 1 chunk +0 lines, -9 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkXfermodeImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/Gr1DKernelEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrBicubicEffect.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/gpu/effects/GrMatrixConvolutionEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrYUVtoRGBEffect.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
bsalomon
Small change peeled off from resource ref counting change.
6 years, 3 months ago (2014-08-29 19:13:45 UTC) #2
robertphillips
lgtm
6 years, 3 months ago (2014-08-29 19:15:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/522873005/1
6 years, 3 months ago (2014-08-29 21:58:49 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-08-29 22:08:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 6267f81f3d60ce144ab2b09ea369420984d5c9d9

Powered by Google App Engine
This is Rietveld 408576698