Issue 521513002: Service Worker: Simplify rejection code in Cache implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 521513002: Service Worker: Simplify rejection code in Cache implementation (Closed)

Created:
6 years, 3 months ago by jsbell

Modified:
6 years, 3 months ago

Reviewers:
jkarlin, gavinp

CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Service Worker: Simplify rejection code in Cache implementation

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+83 lines, -119 lines)			Patch
M	Source/modules/serviceworkers/Cache.h	View	2 chunks	+16 lines, -16 lines	0 comments	Download
M	Source/modules/serviceworkers/Cache.cpp	View	4 chunks	+47 lines, -83 lines	0 comments	Download
M	Source/modules/serviceworkers/Cache.idl	View	1 chunk	+20 lines, -20 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jsbell

jsbell@chromium.org changed reviewers: + gavinp@chromium.org, jkarlin@chromium.org

6 years, 3 months ago (2014-08-29 00:54:26 UTC) #1

jsbell

Just FYI. It may not be worth incorporating this, but it demonstrates how to simplify ...

6 years, 3 months ago (2014-08-29 00:54:26 UTC) #2

gavinp

6 years, 3 months ago (2014-08-29 13:45:27 UTC) #3

On 2014/08/29 00:54:26, jsbell wrote:
> Just FYI. It may not be worth incorporating this, but it demonstrates how to
> simplify the logic around Promise-returning methods that reject based on
input.

Thanks. It turns out ScriptPromise::rejectWithDomException makes the code for
this similarly simple

Expand Messages | Collapse Messages