Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1179)

Unified Diff: Source/modules/serviceworkers/Cache.h

Issue 521513002: Service Worker: Simplify rejection code in Cache implementation (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/modules/serviceworkers/Cache.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/serviceworkers/Cache.h
diff --git a/Source/modules/serviceworkers/Cache.h b/Source/modules/serviceworkers/Cache.h
index 219da13d382545a27c9d988a4338755d37f99f5b..b43e4e6ba0e4759e6fe75f11ec2d880f0a0ab2f4 100644
--- a/Source/modules/serviceworkers/Cache.h
+++ b/Source/modules/serviceworkers/Cache.h
@@ -34,20 +34,20 @@ public:
virtual ~Cache();
// From Cache.idl:
- ScriptPromise match(ScriptState*, Request*, const Dictionary& queryParams);
- ScriptPromise match(ScriptState*, const String&, const Dictionary& queryParams);
- ScriptPromise matchAll(ScriptState*, Request*, const Dictionary& queryParams);
- ScriptPromise matchAll(ScriptState*, const String&, const Dictionary& queryParams);
- ScriptPromise add(ScriptState*, Request*);
- ScriptPromise add(ScriptState*, const String&);
- ScriptPromise addAll(ScriptState*, const Vector<ScriptValue>&);
- ScriptPromise deleteFunction(ScriptState*, Request*, const Dictionary& queryParams);
- ScriptPromise deleteFunction(ScriptState*, const String&, const Dictionary& queryParams);
- ScriptPromise put(ScriptState*, Request*, Response*);
- ScriptPromise put(ScriptState*, const String&, Response*);
- ScriptPromise keys(ScriptState*);
- ScriptPromise keys(ScriptState*, Request*, const Dictionary& queryParams);
- ScriptPromise keys(ScriptState*, const String&, const Dictionary& queryParams);
+ ScriptPromise match(ScriptState*, Request*, const Dictionary& queryParams, ExceptionState&);
+ ScriptPromise match(ScriptState*, const String&, const Dictionary& queryParams, ExceptionState&);
+ ScriptPromise matchAll(ScriptState*, Request*, const Dictionary& queryParams, ExceptionState&);
+ ScriptPromise matchAll(ScriptState*, const String&, const Dictionary& queryParams, ExceptionState&);
+ ScriptPromise add(ScriptState*, Request*, ExceptionState&);
+ ScriptPromise add(ScriptState*, const String&, ExceptionState&);
+ ScriptPromise addAll(ScriptState*, const Vector<ScriptValue>&, ExceptionState&);
+ ScriptPromise deleteFunction(ScriptState*, Request*, const Dictionary& queryParams, ExceptionState&);
+ ScriptPromise deleteFunction(ScriptState*, const String&, const Dictionary& queryParams, ExceptionState&);
+ ScriptPromise put(ScriptState*, Request*, Response*, ExceptionState&);
+ ScriptPromise put(ScriptState*, const String&, Response*, ExceptionState&);
+ ScriptPromise keys(ScriptState*, ExceptionState&);
+ ScriptPromise keys(ScriptState*, Request*, const Dictionary& queryParams, ExceptionState&);
+ ScriptPromise keys(ScriptState*, const String&, const Dictionary& queryParams, ExceptionState&);
void trace(Visitor*) { }
@@ -60,8 +60,8 @@ private:
ScriptPromise matchImpl(ScriptState*, PassRefPtrWillBeRawPtr<Request>, const Dictionary& queryParams);
ScriptPromise matchAllImpl(ScriptState*, PassRefPtrWillBeRawPtr<Request>, const Dictionary& queryParams);
- ScriptPromise addImpl(ScriptState*, PassRefPtrWillBeRawPtr<Request>);
- ScriptPromise addAllImpl(ScriptState*, Vector<RefPtrWillBeRawPtr<Request> >);
+ ScriptPromise addImpl(ScriptState*, PassRefPtrWillBeRawPtr<Request>, ExceptionState&);
+ ScriptPromise addAllImpl(ScriptState*, Vector<RefPtrWillBeRawPtr<Request> >, ExceptionState&);
ScriptPromise deleteImpl(ScriptState*, PassRefPtrWillBeRawPtr<Request>, const Dictionary& queryParams);
ScriptPromise putImpl(ScriptState*, PassRefPtrWillBeRawPtr<Request>, Response*);
ScriptPromise keysImpl(ScriptState*);
« no previous file with comments | « no previous file | Source/modules/serviceworkers/Cache.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698