Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1480)

Unified Diff: Source/modules/serviceworkers/Cache.idl

Issue 521513002: Service Worker: Simplify rejection code in Cache implementation (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/serviceworkers/Cache.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/serviceworkers/Cache.idl
diff --git a/Source/modules/serviceworkers/Cache.idl b/Source/modules/serviceworkers/Cache.idl
index aadbe2228b8e8c6796e278ae1be38f3e4b1d1dbf..d4b99a9f66af30ecd2f3efa0eb68d1f960dc0484 100644
--- a/Source/modules/serviceworkers/Cache.idl
+++ b/Source/modules/serviceworkers/Cache.idl
@@ -23,32 +23,32 @@
] interface Cache {
// FIXME: Blink doesn't support union types, we use overrides instead. See http://crbug.com/240176
- // [CallWith=ScriptState] Promise match((Request or ScalarValueString) request, optional Dictionary queryParams);
- [CallWith=ScriptState] Promise match(Request request, optional Dictionary queryParams);
- [CallWith=ScriptState] Promise match(ScalarValueString request, optional Dictionary queryParams);
+ // [CallWith=ScriptState, RaisesException] Promise match((Request or ScalarValueString) request, optional Dictionary queryParams);
+ [CallWith=ScriptState, RaisesException] Promise match(Request request, optional Dictionary queryParams);
+ [CallWith=ScriptState, RaisesException] Promise match(ScalarValueString request, optional Dictionary queryParams);
- // [CallWith=ScriptState] Promise matchAll((Request or ScalarValueString) request, optional Dictionary queryParams);
- [CallWith=ScriptState] Promise matchAll(Request request, optional Dictionary queryParams);
- [CallWith=ScriptState] Promise matchAll(ScalarValueString request, optional Dictionary queryParams);
+ // [CallWith=ScriptState, RaisesException] Promise matchAll((Request or ScalarValueString) request, optional Dictionary queryParams);
+ [CallWith=ScriptState, RaisesException] Promise matchAll(Request request, optional Dictionary queryParams);
+ [CallWith=ScriptState, RaisesException] Promise matchAll(ScalarValueString request, optional Dictionary queryParams);
- // [CallWith=ScriptState] Promise add((Request or ScalarValueString) request);
- [CallWith=ScriptState] Promise add(Request request);
- [CallWith=ScriptState] Promise add(ScalarValueString request);
+ // [CallWith=ScriptState, RaisesException] Promise add((Request or ScalarValueString) request);
+ [CallWith=ScriptState, RaisesException] Promise add(Request request);
+ [CallWith=ScriptState, RaisesException] Promise add(ScalarValueString request);
// FIXME: The lack of union type support together with the sequence mean we can't use overrides here, instead
// bind a generic type.
- // [CallWith=ScriptState] Promise addAll(sequence<Request or ScalarValueString> requests);
- [CallWith=ScriptState] Promise addAll(sequence<any> requests);
+ // [CallWith=ScriptState, RaisesException] Promise addAll(sequence<Request or ScalarValueString> requests);
+ [CallWith=ScriptState, RaisesException] Promise addAll(sequence<any> requests);
- // [CallWith=ScriptState] Promise put((Request or ScalarValueString) request, Response response);
- [CallWith=ScriptState] Promise put(Request request, Response response);
- [CallWith=ScriptState] Promise put(ScalarValueString request, Response response);
+ // [CallWith=ScriptState, RaisesException] Promise put((Request or ScalarValueString) request, Response response);
+ [CallWith=ScriptState, RaisesException] Promise put(Request request, Response response);
+ [CallWith=ScriptState, RaisesException] Promise put(ScalarValueString request, Response response);
- // [CallWith=ScriptState] Promise delete((Request or ScalarValueString) request, optional Dictionary queryParams);
- [CallWith=ScriptState, ImplementedAs=deleteFunction] Promise delete(Request request, optional Dictionary queryParams);
- [CallWith=ScriptState, ImplementedAs=deleteFunction] Promise delete(ScalarValueString request, optional Dictionary queryParams);
+ // [CallWith=ScriptState, RaisesException] Promise delete((Request or ScalarValueString) request, optional Dictionary queryParams);
+ [CallWith=ScriptState, RaisesException, ImplementedAs=deleteFunction] Promise delete(Request request, optional Dictionary queryParams);
+ [CallWith=ScriptState, RaisesException, ImplementedAs=deleteFunction] Promise delete(ScalarValueString request, optional Dictionary queryParams);
- // [CallWith=ScriptState] Promise keys(optional (Request or ScalarValueString) request, optional Dictionary queryParams);
- [CallWith=ScriptState] Promise keys(optional Request request, optional Dictionary queryParams);
- [CallWith=ScriptState] Promise keys(ScalarValueString request, optional Dictionary queryParams);
+ // [CallWith=ScriptState, RaisesException] Promise keys(optional (Request or ScalarValueString) request, optional Dictionary queryParams);
+ [CallWith=ScriptState, RaisesException] Promise keys(optional Request request, optional Dictionary queryParams);
+ [CallWith=ScriptState, RaisesException] Promise keys(ScalarValueString request, optional Dictionary queryParams);
};
« no previous file with comments | « Source/modules/serviceworkers/Cache.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698