tools/telemetry/telemetry/core/backends/google_credentials_backend.py - Issue 520683002: Re-reenable memory tests. Fixed sign-in issue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/google_credentials_backend.py

Issue 520683002: Re-reenable memory tests. Fixed sign-in issue. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/perf/page_sets/data/mobile_memory_018.wpr.sha1 ('k') | tools/telemetry/telemetry/core/backends/google_credentials_backend_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/google_credentials_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/google_credentials_backend.py b/tools/telemetry/telemetry/core/backends/google_credentials_backend.py

index 780a5ea1f2f11ceb062c71feb5b8ce14fe15f8d4..34d2d5c747887283e22e78eb80d513c94e618b33 100644

--- a/tools/telemetry/telemetry/core/backends/google_credentials_backend.py

+++ b/tools/telemetry/telemetry/core/backends/google_credentials_backend.py

@@ -17,7 +17,11 @@ class GoogleCredentialsBackend(

@property

def url(self):

- return 'https://accounts.google.com/'

+ # pylint: disable=C0301

+ # WPR doesn't support having 2 responses for the same URL (with/without

+ # session cookie), so after login behaviour differs with/without wpr.

+ # Sign-in URL is specified directly to overcome this.

+ return 'https://accounts.google.com/ServiceLogin?continue=https%3A%2F%2Faccounts.google.com%2FManageAccount'

@property

def login_form_id(self):