Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 491863003: Re-enable memory tests. Fixed sign-in issue. (Closed)

Created:
6 years, 4 months ago by Victor Starodub
Modified:
6 years, 3 months ago
Reviewers:
Sami
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Re-enable memory tests. Fixed sign-in issue. Re-recording other tests may be required. BUG=370977 Committed: https://crrev.com/703621781308560423bc1792edf662bb85c7afdc Cr-Commit-Position: refs/heads/master@{#292168}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added the recording hash file. #

Patch Set 3 : Ingoring linter error on URL. Fixed unittest. #

Patch Set 4 : Added the hash file again. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M tools/perf/benchmarks/memory.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/page_sets/data/mobile_memory.json View 1 chunk +5 lines, -5 lines 0 comments Download
A tools/perf/page_sets/data/mobile_memory_018.wpr.sha1 View 1 3 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/google_credentials_backend.py View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/google_credentials_backend_unittest.py View 1 2 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
Victor Starodub
Please take a look. Is there any way to try this change before submitting? I'm ...
6 years, 4 months ago (2014-08-22 11:34:01 UTC) #1
Sami
Fix looks correct, but can you make sure the hash for the new recording gets ...
6 years, 4 months ago (2014-08-22 12:28:14 UTC) #2
Victor Starodub
Couldn't find any other failing tests. Seems like the sign-in portion of the test is ...
6 years, 3 months ago (2014-08-26 11:54:37 UTC) #3
Victor Starodub
The CQ bit was checked by starodub@google.com
6 years, 3 months ago (2014-08-26 11:55:08 UTC) #4
Victor Starodub
The CQ bit was unchecked by starodub@google.com
6 years, 3 months ago (2014-08-26 11:55:09 UTC) #5
Victor Starodub
The CQ bit was checked by starodub@google.com
6 years, 3 months ago (2014-08-26 11:56:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/starodub@google.com/491863003/20001
6 years, 3 months ago (2014-08-26 11:56:54 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-26 11:56:55 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-08-26 11:56:56 UTC) #9
Sami
lgtm.
6 years, 3 months ago (2014-08-26 12:01:15 UTC) #10
Victor Starodub
The CQ bit was checked by starodub@google.com
6 years, 3 months ago (2014-08-26 13:14:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/starodub@google.com/491863003/20001
6 years, 3 months ago (2014-08-26 13:15:37 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-26 14:13:53 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-26 14:17:45 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/6665)
6 years, 3 months ago (2014-08-26 14:17:46 UTC) #15
Victor Starodub
The CQ bit was checked by starodub@google.com
6 years, 3 months ago (2014-08-27 14:57:03 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/starodub@google.com/491863003/40001
6 years, 3 months ago (2014-08-27 14:57:57 UTC) #17
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-08-27 15:56:34 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 383ffaab6b5fac34b950d9faaab637cc75907aca
6 years, 3 months ago (2014-08-27 16:56:04 UTC) #19
tonyg
A revert of this CL (patchset #3) has been created in https://codereview.chromium.org/511023002/ by tonyg@chromium.org. The ...
6 years, 3 months ago (2014-08-27 23:10:38 UTC) #20
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:52:13 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/703621781308560423bc1792edf662bb85c7afdc
Cr-Commit-Position: refs/heads/master@{#292168}

Powered by Google App Engine
This is Rietveld 408576698