Remove PrerenderManager.enabled_ and related members.

Remove PrerenderManager.enabled_ and related members.

Code cleanup:  Remove network_prediction_enabled_ from NetPrefObserver, and
enabled_ and set_enabled() from PrerenderManager.  Earlier CLs on this issue
update the Prerender mechanism and make these members/methods obsolete.

BUG=334602
Committed: https://crrev.com/2551612c872f85e4f79c5d98ca21e0968239f6ae
Cr-Commit-Position: refs/heads/master@{#293242}

[Bence, 2014-09-03 12:54:21]

bnc@chromium.org changed reviewers:
+ dbeam@chromium.org, mmenke@chromium.org

[Bence, 2014-09-03 12:54:21]

dbeam@chromium.org: Please review changes in
chrome/test/data/webui/net_internals/prerender_view.js.

mmenke@chromium.org: Please review changes in chrome/browser/*.

Thank you.

[mmenke, 2014-09-03 14:30:55]

https://codereview.chromium.org/519583005/diff/20001/chrome/browser/net/net_p...
File chrome/browser/net/net_pref_observer.cc (right):

https://codereview.chromium.org/519583005/diff/20001/chrome/browser/net/net_p...
chrome/browser/net/net_pref_observer.cc:8: #include
"chrome/browser/chrome_notification_types.h"
While you're here...I don't think this is used?

https://codereview.chromium.org/519583005/diff/20001/chrome/browser/net/net_p...
chrome/browser/net/net_pref_observer.cc:10: #include
"chrome/browser/prerender/prerender_manager.h"
Not needed.

https://codereview.chromium.org/519583005/diff/20001/chrome/browser/net/net_p...
File chrome/browser/net/net_pref_observer.h (right):

https://codereview.chromium.org/519583005/diff/20001/chrome/browser/net/net_p...
chrome/browser/net/net_pref_observer.h:34: prerender::PrerenderManager*
prerender_manager,
This isn't needed any more, and can get rid of the forward declaration, too. 
Same goes for the Predictor, I believe.

https://codereview.chromium.org/519583005/diff/20001/chrome/browser/net/net_p...
chrome/browser/net/net_pref_observer.h:44: chrome_browser_net::Predictor*
predictor_;
Don't believe this is needed any more.

https://codereview.chromium.org/519583005/diff/20001/chrome/browser/prerender...
File chrome/browser/prerender/prerender_manager.cc (right):

https://codereview.chromium.org/519583005/diff/20001/chrome/browser/prerender...
chrome/browser/prerender/prerender_manager.cc:930:
dict_value->SetBoolean("omnibox_enabled", IsOmniboxEnabled(profile_));
Should keep the value you removed here, and just set it to IsEnabled().

Maybe it should really be IsEnabled() && IsPrerenderingPossible(), but think
that's beyond the scope of this CL, and I may be forgetting something.

https://codereview.chromium.org/519583005/diff/20001/chrome/test/data/webui/n...
File chrome/test/data/webui/net_internals/prerender_view.js (right):

https://codereview.chromium.org/519583005/diff/20001/chrome/test/data/webui/n...
chrome/test/data/webui/net_internals/prerender_view.js:89: // Check number of
rows in both tables.
Per comment in other file, should add this back.

[Bence, 2014-09-03 15:25:42]

Patchset #3 (id:40001) has been deleted

[Bence, 2014-09-03 15:36:16]

Patchset #3 (id:60001) has been deleted

[Bence, 2014-09-03 17:05:17]

bnc@chromium.org changed reviewers:
- dbeam@chromium.org

[Bence, 2014-09-03 17:05:18]

PTAL.

https://codereview.chromium.org/519583005/diff/20001/chrome/browser/net/net_p...
File chrome/browser/net/net_pref_observer.cc (right):

https://codereview.chromium.org/519583005/diff/20001/chrome/browser/net/net_p...
chrome/browser/net/net_pref_observer.cc:8: #include
"chrome/browser/chrome_notification_types.h"
On 2014/09/03 14:30:55, mmenke wrote:
> While you're here...I don't think this is used?

Done.

https://codereview.chromium.org/519583005/diff/20001/chrome/browser/net/net_p...
chrome/browser/net/net_pref_observer.cc:10: #include
"chrome/browser/prerender/prerender_manager.h"
On 2014/09/03 14:30:55, mmenke wrote:
> Not needed.

Done.

https://codereview.chromium.org/519583005/diff/20001/chrome/browser/net/net_p...
File chrome/browser/net/net_pref_observer.h (right):

https://codereview.chromium.org/519583005/diff/20001/chrome/browser/net/net_p...
chrome/browser/net/net_pref_observer.h:8: #include "base/basictypes.h"
What do we need this for?

https://codereview.chromium.org/519583005/diff/20001/chrome/browser/net/net_p...
chrome/browser/net/net_pref_observer.h:34: prerender::PrerenderManager*
prerender_manager,
On 2014/09/03 14:30:55, mmenke wrote:
> This isn't needed any more, and can get rid of the forward declaration, too. 
> Same goes for the Predictor, I believe.

Done.

https://codereview.chromium.org/519583005/diff/20001/chrome/browser/net/net_p...
chrome/browser/net/net_pref_observer.h:44: chrome_browser_net::Predictor*
predictor_;
On 2014/09/03 14:30:55, mmenke wrote:
> Don't believe this is needed any more.

Done.

https://codereview.chromium.org/519583005/diff/20001/chrome/browser/prerender...
File chrome/browser/prerender/prerender_manager.cc (right):

https://codereview.chromium.org/519583005/diff/20001/chrome/browser/prerender...
chrome/browser/prerender/prerender_manager.cc:930:
dict_value->SetBoolean("omnibox_enabled", IsOmniboxEnabled(profile_));
On 2014/09/03 14:30:55, mmenke wrote:
> Should keep the value you removed here, and just set it to IsEnabled().
> 
> Maybe it should really be IsEnabled() && IsPrerenderingPossible(), but think
> that's beyond the scope of this CL, and I may be forgetting something.

Done.

https://codereview.chromium.org/519583005/diff/20001/chrome/test/data/webui/n...
File chrome/test/data/webui/net_internals/prerender_view.js (right):

https://codereview.chromium.org/519583005/diff/20001/chrome/test/data/webui/n...
chrome/test/data/webui/net_internals/prerender_view.js:89: // Check number of
rows in both tables.
On 2014/09/03 14:30:55, mmenke wrote:
> Per comment in other file, should add this back.

Done.

[mmenke, 2014-09-03 17:17:59]

LGTM, just comments about the pre-existing headers.

https://codereview.chromium.org/519583005/diff/20001/chrome/browser/net/net_p...
File chrome/browser/net/net_pref_observer.h (right):

https://codereview.chromium.org/519583005/diff/20001/chrome/browser/net/net_p...
chrome/browser/net/net_pref_observer.h:8: #include "base/basictypes.h"
On 2014/09/03 17:05:17, Bence wrote:
> What do we need this for?

We need it for DISALLOW_COPY_AND_ASSIGN.  You could use macros.h instead, which
is where it's actually defined, currently (It used to be in basictypes, IIRC,
but it moved, though basictypes still includes macros.h)

https://codereview.chromium.org/519583005/diff/80001/chrome/browser/net/net_p...
File chrome/browser/net/net_pref_observer.cc (right):

https://codereview.chromium.org/519583005/diff/80001/chrome/browser/net/net_p...
chrome/browser/net/net_pref_observer.cc:16:
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
Mind adding base/logging.h, while you're here, for DCHECK?

https://codereview.chromium.org/519583005/diff/80001/chrome/browser/net/net_p...
chrome/browser/net/net_pref_observer.cc:20: base::Unretained(this));
And base/bind.h.

We need an IWYU preprocessor.  :(

[Bence, 2014-09-03 18:30:01]

The CQ bit was checked by bnc@chromium.org

[Bence, 2014-09-03 18:30:14]

Thank you.

https://codereview.chromium.org/519583005/diff/20001/chrome/browser/net/net_p...
File chrome/browser/net/net_pref_observer.h (right):

https://codereview.chromium.org/519583005/diff/20001/chrome/browser/net/net_p...
chrome/browser/net/net_pref_observer.h:8: #include "base/basictypes.h"
Changed to macros.h.

https://codereview.chromium.org/519583005/diff/80001/chrome/browser/net/net_p...
File chrome/browser/net/net_pref_observer.cc (right):

https://codereview.chromium.org/519583005/diff/80001/chrome/browser/net/net_p...
chrome/browser/net/net_pref_observer.cc:16:
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
On 2014/09/03 17:17:58, mmenke wrote:
> Mind adding base/logging.h, while you're here, for DCHECK?

Done.

[commit-bot: I haz the power, 2014-09-03 18:38:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bnc@chromium.org/519583005/100001

[commit-bot: I haz the power, 2014-09-03 22:39:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-03 22:39:22]

Failed to commit the patch.

[Bence, 2014-09-04 00:45:38]

The CQ bit was checked by bnc@chromium.org

[commit-bot: I haz the power, 2014-09-04 00:47:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bnc@chromium.org/519583005/100001

[commit-bot: I haz the power, 2014-09-04 00:49:33]

Committed patchset #4 (id:100001) as 83193bc16f0d52cc539d844dded759bfed1f35f5

[commit-bot: I haz the power, 2014-09-10 03:29:13]

Patchset 4 (id:??) landed as
https://crrev.com/2551612c872f85e4f79c5d98ca21e0968239f6ae
Cr-Commit-Position: refs/heads/master@{#293242}