Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Side by Side Diff: chrome/browser/net/net_pref_observer.cc

Issue 519583005: Remove PrerenderManager.enabled_ and related members. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Re: #3. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/net/net_pref_observer.h ('k') | chrome/browser/prerender/prerender_manager.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/net/net_pref_observer.h" 5 #include "chrome/browser/net/net_pref_observer.h"
6 6
7 #include "base/prefs/pref_service.h" 7 #include "base/prefs/pref_service.h"
8 #include "chrome/browser/chrome_notification_types.h"
9 #include "chrome/browser/net/predictor.h"
10 #include "chrome/browser/prerender/prerender_manager.h"
11 #include "chrome/common/pref_names.h" 8 #include "chrome/common/pref_names.h"
12 #include "components/pref_registry/pref_registry_syncable.h" 9 #include "components/pref_registry/pref_registry_syncable.h"
13 #include "content/public/browser/browser_thread.h" 10 #include "content/public/browser/browser_thread.h"
14 #include "net/http/http_stream_factory.h" 11 #include "net/http/http_stream_factory.h"
15 12
16 using content::BrowserThread; 13 using content::BrowserThread;
17 14
18 NetPrefObserver::NetPrefObserver(PrefService* prefs, 15 NetPrefObserver::NetPrefObserver(PrefService* prefs) {
19 prerender::PrerenderManager* prerender_manager,
20 chrome_browser_net::Predictor* predictor)
21 : prerender_manager_(prerender_manager),
22 predictor_(predictor) {
23 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 16 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
mmenke 2014/09/03 17:17:58 Mind adding base/logging.h, while you're here, for
Bence 2014/09/03 18:30:14 Done.
24 DCHECK(prefs); 17 DCHECK(prefs);
25 DCHECK(predictor);
26 18
27 base::Closure prefs_callback = base::Bind(&NetPrefObserver::ApplySettings, 19 base::Closure prefs_callback = base::Bind(&NetPrefObserver::ApplySettings,
28 base::Unretained(this)); 20 base::Unretained(this));
mmenke 2014/09/03 17:17:58 And base/bind.h. We need an IWYU preprocessor. :
29 network_prediction_enabled_.Init(prefs::kNetworkPredictionEnabled, prefs,
30 prefs_callback);
31 spdy_disabled_.Init(prefs::kDisableSpdy, prefs, prefs_callback); 21 spdy_disabled_.Init(prefs::kDisableSpdy, prefs, prefs_callback);
32 22
33 ApplySettings(); 23 ApplySettings();
34 } 24 }
35 25
36 NetPrefObserver::~NetPrefObserver() { 26 NetPrefObserver::~NetPrefObserver() {
37 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 27 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
38 } 28 }
39 29
40 void NetPrefObserver::ApplySettings() { 30 void NetPrefObserver::ApplySettings() {
41 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 31 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
42 32
43 if (prerender_manager_)
44 prerender_manager_->set_enabled(*network_prediction_enabled_);
45 if (spdy_disabled_.IsManaged()) 33 if (spdy_disabled_.IsManaged())
46 net::HttpStreamFactory::set_spdy_enabled(!*spdy_disabled_); 34 net::HttpStreamFactory::set_spdy_enabled(!*spdy_disabled_);
47 } 35 }
48 36
49 // static 37 // static
50 void NetPrefObserver::RegisterProfilePrefs( 38 void NetPrefObserver::RegisterProfilePrefs(
51 user_prefs::PrefRegistrySyncable* registry) { 39 user_prefs::PrefRegistrySyncable* registry) {
52 registry->RegisterBooleanPref( 40 registry->RegisterBooleanPref(
53 prefs::kNetworkPredictionEnabled, 41 prefs::kNetworkPredictionEnabled,
54 true, 42 true,
55 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF); 43 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
56 registry->RegisterBooleanPref( 44 registry->RegisterBooleanPref(
57 prefs::kDisableSpdy, 45 prefs::kDisableSpdy,
58 false, 46 false,
59 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF); 47 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
60 } 48 }
OLDNEW
« no previous file with comments | « chrome/browser/net/net_pref_observer.h ('k') | chrome/browser/prerender/prerender_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698