Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Side by Side Diff: chrome/browser/net/net_pref_observer.h

Issue 519583005: Remove PrerenderManager.enabled_ and related members. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove enabled from prerender_view.js. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_NET_NET_PREF_OBSERVER_H_ 5 #ifndef CHROME_BROWSER_NET_NET_PREF_OBSERVER_H_
6 #define CHROME_BROWSER_NET_NET_PREF_OBSERVER_H_ 6 #define CHROME_BROWSER_NET_NET_PREF_OBSERVER_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
Bence 2014/09/03 17:05:17 What do we need this for?
mmenke 2014/09/03 17:17:58 We need it for DISALLOW_COPY_AND_ASSIGN. You coul
Bence 2014/09/03 18:30:14 Changed to macros.h.
9 #include "base/prefs/pref_member.h" 9 #include "base/prefs/pref_member.h"
10 10
11 class PrefService; 11 class PrefService;
12 12
13 namespace chrome_browser_net { 13 namespace chrome_browser_net {
14 class Predictor; 14 class Predictor;
15 } 15 }
16 16
17 namespace prerender { 17 namespace prerender {
18 class PrerenderManager; 18 class PrerenderManager;
19 } 19 }
20 20
21 namespace user_prefs { 21 namespace user_prefs {
22 class PrefRegistrySyncable; 22 class PrefRegistrySyncable;
23 } 23 }
24 24
25 // Monitors network-related preferences for changes and applies them. 25 // Monitors network-related preferences for changes and applies them.
26 // The supplied PrefService must outlive this NetPrefObserver. 26 // The supplied PrefService must outlive this NetPrefObserver.
27 // Must be used only on the UI thread. 27 // Must be used only on the UI thread.
28 class NetPrefObserver { 28 class NetPrefObserver {
29 public: 29 public:
30 // |prefs| must be non-NULL and |*prefs| must outlive this. 30 // |prefs| must be non-NULL and |*prefs| must outlive this.
31 // |prerender_manager| may be NULL. If not, |*prerender_manager| must 31 // |prerender_manager| may be NULL. If not, |*prerender_manager| must
32 // outlive this. 32 // outlive this.
33 NetPrefObserver(PrefService* prefs, 33 NetPrefObserver(PrefService* prefs,
34 prerender::PrerenderManager* prerender_manager, 34 prerender::PrerenderManager* prerender_manager,
mmenke 2014/09/03 14:30:55 This isn't needed any more, and can get rid of the
Bence 2014/09/03 17:05:17 Done.
35 chrome_browser_net::Predictor* predictor); 35 chrome_browser_net::Predictor* predictor);
36 virtual ~NetPrefObserver(); 36 virtual ~NetPrefObserver();
37 37
38 static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry); 38 static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);
39 39
40 private: 40 private:
41 void ApplySettings(); 41 void ApplySettings();
42 42
43 BooleanPrefMember network_prediction_enabled_;
44 BooleanPrefMember spdy_disabled_; 43 BooleanPrefMember spdy_disabled_;
45 prerender::PrerenderManager* prerender_manager_;
46 chrome_browser_net::Predictor* predictor_; 44 chrome_browser_net::Predictor* predictor_;
mmenke 2014/09/03 14:30:55 Don't believe this is needed any more.
Bence 2014/09/03 17:05:17 Done.
47 45
48 DISALLOW_COPY_AND_ASSIGN(NetPrefObserver); 46 DISALLOW_COPY_AND_ASSIGN(NetPrefObserver);
49 }; 47 };
50 48
51 #endif // CHROME_BROWSER_NET_NET_PREF_OBSERVER_H_ 49 #endif // CHROME_BROWSER_NET_NET_PREF_OBSERVER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/net/net_pref_observer.cc » ('j') | chrome/browser/net/net_pref_observer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698