Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 517843002: ChromeVox is using Array.every in three places where it should be forEach. (Closed)

Created:
6 years, 3 months ago by dmazzoni
Modified:
6 years, 3 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nkostylev+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

ChromeVox is using Array.every in three places where it should be forEach. This is causing problems when a function that returns an array of nav descriptions returns more than one item, they're not all processed correctly. BUG=408821 Committed: https://crrev.com/0c6474993b5e60952434a81391963d581b539418 Cr-Commit-Position: refs/heads/master@{#292844}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js View 1 chunk +1 line, -1 line 1 comment Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/navigation_manager.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
dmazzoni
dmazzoni@chromium.org changed reviewers: + dtseng@chromium.org
6 years, 3 months ago (2014-08-28 22:59:56 UTC) #1
dmazzoni
6 years, 3 months ago (2014-08-28 22:59:56 UTC) #2
David Tseng
lgtm https://codereview.chromium.org/517843002/diff/1/chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js File chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js (left): https://codereview.chromium.org/517843002/diff/1/chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js#oldcode407 chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js:407: navDescriptions.every(function(desc) { I wonder if the Closure compiler ...
6 years, 3 months ago (2014-08-29 16:55:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/517843002/1
6 years, 3 months ago (2014-09-01 06:42:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 69ddceabaf1244d97f8aea48cb3da79603a9ab03
6 years, 3 months ago (2014-09-01 08:08:44 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:15:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c6474993b5e60952434a81391963d581b539418
Cr-Commit-Position: refs/heads/master@{#292844}

Powered by Google App Engine
This is Rietveld 408576698