chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js - Issue 517843002: ChromeVox is using Array.every in three places where it should be forEach.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js

Issue 517843002: ChromeVox is using Array.every in three places where it should be forEach. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js

diff --git a/chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js b/chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js

index 07fa9bd460fbde95365e2dc20d096313a24b2db6..c8a8a1792df8b67c6e0be4e8edf1c11440409154 100644

--- a/chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js

+++ b/chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js

@@ -404,7 +404,7 @@ cvox.LiveRegions.announceChange = function(

// Set a category on the NavDescriptions - that way live regions

// interrupt other live regions but not anything else.

- navDescriptions.every(function(desc) {

David Tseng 2014/08/29 16:55:23 I wonder if the Closure compiler can warn us of un

+ navDescriptions.forEach(function(desc) {

if (!desc.category) {

desc.category = 'live';

}

« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/chromevox/chromevox/injected/navigation_manager.js » ('j') | no next file with comments »