chrome/browser/resources/chromeos/chromevox/chromevox/injected/navigation_manager.js - Issue 517843002: ChromeVox is using Array.every in three places where it should be forEach.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/chromevox/injected/navigation_manager.js

Issue 517843002: ChromeVox is using Array.every in three places where it should be forEach. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js ('K') | « chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/chromevox/injected/navigation_manager.js

diff --git a/chrome/browser/resources/chromeos/chromevox/chromevox/injected/navigation_manager.js b/chrome/browser/resources/chromeos/chromevox/chromevox/injected/navigation_manager.js

index a7236cddd27f0c14660574fb4def163cada58963..39e355bdd5ffb62ec7f0bb61da768608a456b33e 100644

--- a/chrome/browser/resources/chromeos/chromevox/chromevox/injected/navigation_manager.js

+++ b/chrome/browser/resources/chromeos/chromevox/chromevox/injected/navigation_manager.js

@@ -647,14 +647,14 @@ cvox.NavigationManager.prototype.speakDescriptionArray = function(

opt_personality,

opt_category) {

if (opt_personality) {

- descriptionArray.every(function(desc) {

+ descriptionArray.forEach(function(desc) {

if (!desc.personality) {

desc.personality = opt_personality;

}

});

}

if (opt_category) {

- descriptionArray.every(function(desc) {

+ descriptionArray.forEach(function(desc) {

if (!desc.category) {

desc.category = opt_category;

}