Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1517)

Unified Diff: Source/web/ExternalPopupMenu.h

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/ExternalPopupMenu.h
diff --git a/Source/web/ExternalPopupMenu.h b/Source/web/ExternalPopupMenu.h
index 25ac59b74f4875b86464cbcf38e080e72ced3f7a..33c683c91095387b7162f5201987793eeeb361be 100644
--- a/Source/web/ExternalPopupMenu.h
+++ b/Source/web/ExternalPopupMenu.h
@@ -56,7 +56,6 @@ public:
ExternalPopupMenu(LocalFrame&, PopupMenuClient*, WebViewImpl&);
virtual ~ExternalPopupMenu();
-
// Fills |info| with the popup menu information contained in the
// PopupMenuClient associated with this ExternalPopupMenu.
// FIXME: public only for test access. Need to revert once gtest
@@ -65,6 +64,8 @@ public:
static int toPopupMenuItemIndex(int index, PopupMenuClient&);
static int toExternalPopupMenuItemIndex(int index, PopupMenuClient&);
+ virtual void trace(Visitor*) OVERRIDE;
+
private:
// PopupMenu methods:
virtual void show(const FloatQuad& controlPosition, const IntSize&, int index) OVERRIDE;
@@ -81,7 +82,7 @@ private:
void dispatchEvent(Timer<ExternalPopupMenu>*);
PopupMenuClient* m_popupMenuClient;
- RefPtr<LocalFrame> m_localFrame;
+ RefPtrWillBeMember<LocalFrame> m_localFrame;
WebViewImpl& m_webView;
OwnPtr<WebMouseEvent> m_syntheticEvent;
Timer<ExternalPopupMenu> m_dispatchEventTimer;

Powered by Google App Engine
This is Rietveld 408576698