Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(889)

Unified Diff: Source/core/page/Page.h

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/page/Page.h
diff --git a/Source/core/page/Page.h b/Source/core/page/Page.h
index e90ae63be7681ce90f8ef858b913b16de1acf503..9ff39f0d9b63a0a35dac935574120cc134b291af 100644
--- a/Source/core/page/Page.h
+++ b/Source/core/page/Page.h
@@ -254,7 +254,7 @@ private:
const OwnPtr<Chrome> m_chrome;
const OwnPtrWillBeMember<DragCaretController> m_dragCaretController;
const OwnPtrWillBeMember<DragController> m_dragController;
- const OwnPtr<FocusController> m_focusController;
+ const OwnPtrWillBeMember<FocusController> m_focusController;
const OwnPtrWillBeMember<ContextMenuController> m_contextMenuController;
const OwnPtrWillBeMember<InspectorController> m_inspectorController;
const OwnPtrWillBeMember<PointerLockController> m_pointerLockController;
@@ -273,7 +273,7 @@ private:
// other, thus keeping each other alive. The call to willBeDestroyed()
// breaks this cycle, so the frame is still properly destroyed once no
// longer needed.
- Frame* m_mainFrame;
+ RawPtrWillBeMember<Frame> m_mainFrame;
mutable RefPtr<PluginData> m_pluginData;

Powered by Google App Engine
This is Rietveld 408576698