Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 516953002: Fix: xcode-ninja should copy the product extension to the wrapper project (Closed)

Created:
6 years, 3 months ago by Tobias
Modified:
6 years ago
Reviewers:
sdefresne, justincohen
CC:
gyp-developer_googlegroups.com, dglazkov
Base URL:
https://chromium.googlesource.com/external/gyp.git@Fix-Xcode-ninja-workspace-4
Visibility:
Public.

Description

Fix: xcode-ninja should copy the product extension to the wrapper project Two targets may differ in just the product extension. To avoid name clashes in this situation, the xcode-ninja generator needs to copy this extension when generating targets for the wrapper project. Patch by Tobias Hahn <tobias.hahn@ableton.com>;. BUG=gyp:450 TEST=./gyptest.py -f xcode-ninja test/mac/gyptest-loadable-module-bundle-product-extension.py R=justincohen@chromium.org, sdefresne@chromium.org, justincohen Committed: https://code.google.com/p/gyp/source/detail?r=2019

Patch Set 1 #

Patch Set 2 : Address sdefresne's feedback to #421453003 #

Patch Set 3 : Rebase onto origin/master #

Patch Set 4 : Rebase onto 421053005 #

Patch Set 5 : Rebase onto 421053005 #

Patch Set 6 : Rebase onto 421053005 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M pylib/gyp/xcode_ninja.py View 1 chunk +3 lines, -0 lines 0 comments Download
M test/mac/gyptest-loadable-module-bundle-product-extension.py View 1 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Tobias
This is a bug I found and fixed while working on Issue 421453003. Thanks for ...
6 years, 3 months ago (2014-08-28 14:58:29 UTC) #1
justincohen
lgtm
6 years, 3 months ago (2014-08-28 15:14:25 UTC) #2
sdefresne
lgtm
6 years ago (2014-12-03 16:13:11 UTC) #4
sdefresne
6 years ago (2014-12-24 08:32:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #6 (id:100001) manually as 2019 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698