Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Unified Diff: pylib/gyp/xcode_ninja.py

Issue 516953002: Fix: xcode-ninja should copy the product extension to the wrapper project (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@Fix-Xcode-ninja-workspace-4
Patch Set: Rebase onto 421053005 Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mac/gyptest-loadable-module-bundle-product-extension.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pylib/gyp/xcode_ninja.py
diff --git a/pylib/gyp/xcode_ninja.py b/pylib/gyp/xcode_ninja.py
index 57e73c64fd7d03f40d13eee9226af3c84df91be9..0aae9bd23bb794ec2c609dce9d8f3fe313ef13cb 100644
--- a/pylib/gyp/xcode_ninja.py
+++ b/pylib/gyp/xcode_ninja.py
@@ -67,10 +67,13 @@ def _TargetFromSpec(old_spec, params):
target_name = old_spec.get('target_name')
product_name = old_spec.get('product_name', target_name)
+ product_extension = old_spec.get('product_extension')
ninja_target = {}
ninja_target['target_name'] = target_name
ninja_target['product_name'] = product_name
+ if product_extension:
+ ninja_target['product_extension'] = product_extension
ninja_target['toolset'] = old_spec.get('toolset')
ninja_target['default_configuration'] = old_spec.get('default_configuration')
ninja_target['configurations'] = {}
« no previous file with comments | « no previous file | test/mac/gyptest-loadable-module-bundle-product-extension.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698