Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: test/mac/gyptest-loadable-module-bundle-product-extension.py

Issue 516953002: Fix: xcode-ninja should copy the product extension to the wrapper project (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@Fix-Xcode-ninja-workspace-4
Patch Set: Rebase onto 421053005 Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pylib/gyp/xcode_ninja.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mac/gyptest-loadable-module-bundle-product-extension.py
diff --git a/test/mac/gyptest-loadable-module-bundle-product-extension.py b/test/mac/gyptest-loadable-module-bundle-product-extension.py
index 82a3d0974b54c50d13fd0c845f14d90702a734e3..7a60ca2d177a018f52c58a139b2d665ae7ba393f 100644
--- a/test/mac/gyptest-loadable-module-bundle-product-extension.py
+++ b/test/mac/gyptest-loadable-module-bundle-product-extension.py
@@ -18,13 +18,11 @@ import sys
if sys.platform == 'darwin':
test = TestGyp.TestGyp(formats=['ninja', 'make', 'xcode'])
- # The xcode-ninja generator fails because it doesn't copy the extension
- # cf. https://code.google.com/p/gyp/issues/detail?id=450
- if test.format == 'xcode-ninja':
- test.skip_test()
-
CHDIR = 'loadable-module-bundle-product-extension'
- test.run_gyp('test.gyp', chdir=CHDIR)
+ test.run_gyp('test.gyp',
+ '-G', 'xcode_ninja_target_pattern=^.*$',
+ chdir=CHDIR)
+
test.build('test.gyp', test.ALL, chdir=CHDIR)
test.must_exist(test.built_file_path('Collide.foo', chdir=CHDIR))
« no previous file with comments | « pylib/gyp/xcode_ninja.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698