Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: tools/gn/item.h

Issue 51693002: GN: toolchain threading cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/input_conversion.cc ('k') | tools/gn/item.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/item.h
diff --git a/tools/gn/item.h b/tools/gn/item.h
index 2538c50a722cffea66a423c9e81e21b6b8bf778c..69115bd7b3e664dd67352834f0daded786d53f67 100644
--- a/tools/gn/item.h
+++ b/tools/gn/item.h
@@ -11,6 +11,7 @@
class Config;
class ItemNode;
+class Settings;
class Target;
class Toolchain;
@@ -18,9 +19,11 @@ class Toolchain;
// graph.
class Item {
public:
- Item(const Label& label);
+ Item(const Settings* settings, const Label& label);
virtual ~Item();
+ const Settings* settings() const { return settings_; }
+
// This is guaranteed to never change after construction so this can be
// accessed from any thread with no locking once the item is constructed.
const Label& label() const { return label_; }
@@ -49,6 +52,7 @@ class Item {
virtual void OnResolved() {}
private:
+ const Settings* settings_;
Label label_;
ItemNode* item_node_;
« no previous file with comments | « tools/gn/input_conversion.cc ('k') | tools/gn/item.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698