tools/gn/input_conversion.cc - Issue 51693002: GN: toolchain threading cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/input_conversion.cc

Issue 51693002: GN: toolchain threading cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/input_conversion.cc

diff --git a/tools/gn/input_conversion.cc b/tools/gn/input_conversion.cc

index 19a8047e882810a89d7367f620ad0cddeb7f0cdd..c40bdba9eab953543407acc7c29d9e37e4908987 100644

--- a/tools/gn/input_conversion.cc

+++ b/tools/gn/input_conversion.cc

@@ -117,9 +117,7 @@ Value ParseString(const std::string& input,

}

BuildSettings build_settings;

- Label empty_label;

- Toolchain toolchain(empty_label);

- Settings settings(&build_settings, &toolchain, std::string());

+ Settings settings(&build_settings, std::string());

Scope scope(&settings);

Err nested_err;

« no previous file with comments | « tools/gn/gyp_helper.cc ('k') | tools/gn/item.h » ('j') | no next file with comments »