tools/gn/gyp_helper.cc - Issue 51693002: GN: toolchain threading cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/gyp_helper.cc

Issue 51693002: GN: toolchain threading cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/gyp_helper.cc

diff --git a/tools/gn/gyp_helper.cc b/tools/gn/gyp_helper.cc

index f69ed8f2097d29a2b0c22d9795694fe17007b4ae..fb669afd123e7f0f677af1deabb34dd6378c8c3f 100644

--- a/tools/gn/gyp_helper.cc

+++ b/tools/gn/gyp_helper.cc

@@ -45,10 +45,10 @@ SourceFile GypHelper::GetGypFileForTarget(const Target* target,

}

std::string GypHelper::GetNameForTarget(const Target* target) const {

- const Toolchain* toolchain = target->settings()->toolchain();

- if (toolchain->is_default())

+ if (target->settings()->is_default())

return target->label().name(); // Default toolchain has no suffix.

- return target->label().name() + "_" + toolchain->label().name();

+ return target->label().name() + "_" +

+ target->settings()->toolchain_label().name();

}

std::string GypHelper::GetFullRefForTarget(const Target* target) const {

« no previous file with comments | « tools/gn/functions.cc ('k') | tools/gn/input_conversion.cc » ('j') | no next file with comments »