ServiceWorker: Change the return value of ServiceWorkerRegistration::unregister to boolean (2/4)

ServiceWorker: Change the return value of ServiceWorkerRegistration::unregister to boolean

1. [Blink] https://codereview.chromium.org/515083002/
2. [Chromium] This patch
3. [Blink] https://codereview.chromium.org/512163002/
4. [Chromium] https://codereview.chromium.org/509283003/

BUG=390894
TEST=N/A

Committed: https://crrev.com/e83a503dbe85d24dae8879fa1f36781bccfb862a
Cr-Commit-Position: refs/heads/master@{#293083}

[shimazu, 2014-08-28 09:41:26]

shimazu@chromium.org changed reviewers:
+ horo@chromium.org, nhiroki@chromium.org

[shimazu, 2014-08-28 09:41:26]

horo@chromium.org: Please review changes in 

nhiroki@chromium.org: Please review changes in

[nhiroki, 2014-08-29 03:20:07]

https://codereview.chromium.org/516823003/diff/20001/content/child/service_wo...
File content/child/service_worker/service_worker_dispatcher.h (right):

https://codereview.chromium.org/516823003/diff/20001/content/child/service_wo...
content/child/service_worker/service_worker_dispatcher.h:54: #endif
Probably you only need to add line 51-53 because you already typedef'ed
WebServiceWorkerProvider::WebServiceWorkerUnregistrationCallbacks in the
blink-side patch. 

nit: s/UnReg/Unreg/

[nhiroki, 2014-08-29 07:27:29]

https://codereview.chromium.org/516823003/diff/40001/content/child/service_wo...
File content/child/service_worker/service_worker_dispatcher.cc (right):

https://codereview.chromium.org/516823003/diff/40001/content/child/service_wo...
content/child/service_worker/service_worker_dispatcher.cc:275:
pending_registration_callbacks_.Lookup(request_id);
Probably we can reach here when the unregisteration failed in the browser-side
(ie. ServiceWorkerDispatcherHost) and hit the DCHECK due to the missing
callback.

https://codereview.chromium.org/516823003/diff/40001/content/child/service_wo...
File content/child/service_worker/web_service_worker_provider_impl.h (right):

https://codereview.chromium.org/516823003/diff/40001/content/child/service_wo...
content/child/service_worker/web_service_worker_provider_impl.h:41:
WebServiceWorkerUnregistrationCallbacks*);
nit: Wrapped function arguments should have 4-space indent.

See:
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Functi...

[horo, 2014-08-29 07:37:19]

lgtm

[shimazu, 2014-09-01 05:35:33]

shimazu@chromium.org changed reviewers:
+ tsepez@chromium.org

[shimazu, 2014-09-01 05:35:34]

tsepez@chromium.org: Please review changes in IPC.

horo@, nhiroki@: could you review again, since some changes are included related
to the next issue?

https://codereview.chromium.org/516823003/diff/40001/content/child/service_wo...
File content/child/service_worker/service_worker_dispatcher.cc (right):

https://codereview.chromium.org/516823003/diff/40001/content/child/service_wo...
content/child/service_worker/service_worker_dispatcher.cc:275:
pending_registration_callbacks_.Lookup(request_id);
On 2014/08/29 07:27:29, nhiroki wrote:
> Probably we can reach here when the unregisteration failed in the browser-side
> (ie. ServiceWorkerDispatcherHost) and hit the DCHECK due to the missing
> callback.

Done.

https://codereview.chromium.org/516823003/diff/40001/content/child/service_wo...
File content/child/service_worker/web_service_worker_provider_impl.h (right):

https://codereview.chromium.org/516823003/diff/40001/content/child/service_wo...
content/child/service_worker/web_service_worker_provider_impl.h:41:
WebServiceWorkerUnregistrationCallbacks*);
On 2014/08/29 07:27:29, nhiroki wrote:
> nit: Wrapped function arguments should have 4-space indent.
> 
> See:
>
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Functi...

Done.

[nhiroki, 2014-09-01 06:42:56]

lgtm

[horo, 2014-09-01 07:03:58]

lgtm

[Tom Sepez, 2014-09-02 17:10:11]

Messages LGTM

[shimazu, 2014-09-02 23:15:08]

The CQ bit was checked by shimazu@chromium.org

[commit-bot: I haz the power, 2014-09-02 23:16:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/shimazu@chromium.org/516823003/60001

[commit-bot: I haz the power, 2014-09-02 23:31:11]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/49281)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/54606)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-09-02 23:34:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-02 23:34:36]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/49290)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[shimazu, 2014-09-03 05:20:39]

The CQ bit was checked by shimazu@chromium.org

[commit-bot: I haz the power, 2014-09-03 05:21:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/shimazu@chromium.org/516823003/80001

[commit-bot: I haz the power, 2014-09-03 06:20:44]

Committed patchset #5 (id:80001) as 2b72df7c25b92f99906722df7bebaa29edb0ea7e

[commit-bot: I haz the power, 2014-09-10 03:23:56]

Patchset 5 (id:??) landed as
https://crrev.com/e83a503dbe85d24dae8879fa1f36781bccfb862a
Cr-Commit-Position: refs/heads/master@{#293083}