Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Side by Side Diff: content/child/service_worker/web_service_worker_provider_impl.h

Issue 516823003: ServiceWorker: Change the return value of ServiceWorkerRegistration::unregister to boolean (2/4) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporate the reviews Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_CHILD_SERVICE_WORKER_WEB_SERVICE_WORKER_PROVIDER_IMPL_H_ 5 #ifndef CONTENT_CHILD_SERVICE_WORKER_WEB_SERVICE_WORKER_PROVIDER_IMPL_H_
6 #define CONTENT_CHILD_SERVICE_WORKER_WEB_SERVICE_WORKER_PROVIDER_IMPL_H_ 6 #define CONTENT_CHILD_SERVICE_WORKER_WEB_SERVICE_WORKER_PROVIDER_IMPL_H_
7 7
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 18 matching lines...) Expand all
29 WebServiceWorkerProviderImpl(ThreadSafeSender* thread_safe_sender, 29 WebServiceWorkerProviderImpl(ThreadSafeSender* thread_safe_sender,
30 ServiceWorkerProviderContext* context); 30 ServiceWorkerProviderContext* context);
31 virtual ~WebServiceWorkerProviderImpl(); 31 virtual ~WebServiceWorkerProviderImpl();
32 32
33 virtual void setClient(blink::WebServiceWorkerProviderClient* client); 33 virtual void setClient(blink::WebServiceWorkerProviderClient* client);
34 34
35 virtual void registerServiceWorker(const blink::WebURL& pattern, 35 virtual void registerServiceWorker(const blink::WebURL& pattern,
36 const blink::WebURL& script_url, 36 const blink::WebURL& script_url,
37 WebServiceWorkerRegistrationCallbacks*); 37 WebServiceWorkerRegistrationCallbacks*);
38 38
39 virtual void unregisterServiceWorker(const blink::WebURL& pattern, 39 virtual void unregisterServiceWorker(
40 WebServiceWorkerRegistrationCallbacks*); 40 const blink::WebURL& pattern,
41 WebServiceWorkerUnregistrationCallbacks*);
nhiroki 2014/08/29 07:27:29 nit: Wrapped function arguments should have 4-spac
shimazu 2014/09/01 05:35:34 Done.
41 42
42 ServiceWorkerProviderContext* context() { return context_.get(); } 43 ServiceWorkerProviderContext* context() { return context_.get(); }
43 44
44 int provider_id() const { return provider_id_; } 45 int provider_id() const { return provider_id_; }
45 46
46 private: 47 private:
47 void RemoveScriptClient(); 48 void RemoveScriptClient();
48 ServiceWorkerDispatcher* GetDispatcher(); 49 ServiceWorkerDispatcher* GetDispatcher();
49 50
50 scoped_refptr<ThreadSafeSender> thread_safe_sender_; 51 scoped_refptr<ThreadSafeSender> thread_safe_sender_;
51 scoped_refptr<ServiceWorkerProviderContext> context_; 52 scoped_refptr<ServiceWorkerProviderContext> context_;
52 const int provider_id_; 53 const int provider_id_;
53 54
54 DISALLOW_COPY_AND_ASSIGN(WebServiceWorkerProviderImpl); 55 DISALLOW_COPY_AND_ASSIGN(WebServiceWorkerProviderImpl);
55 }; 56 };
56 57
57 } // namespace content 58 } // namespace content
58 59
59 #endif // CONTENT_CHILD_SERVICE_WORKER_WEB_SERVICE_WORKER_PROVIDER_IMPL_H_ 60 #endif // CONTENT_CHILD_SERVICE_WORKER_WEB_SERVICE_WORKER_PROVIDER_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698