content/child/service_worker/web_service_worker_provider_impl.cc - Issue 516823003: ServiceWorker: Change the return value of ServiceWorkerRegistration::unregister to boolean (2/4)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/service_worker/web_service_worker_provider_impl.cc

Issue 516823003: ServiceWorker: Change the return value of ServiceWorkerRegistration::unregister to boolean (2/4) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/child/service_worker/web_service_worker_provider_impl.h ('k') | content/common/service_worker/service_worker_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/service_worker/web_service_worker_provider_impl.cc

diff --git a/content/child/service_worker/web_service_worker_provider_impl.cc b/content/child/service_worker/web_service_worker_provider_impl.cc

index ca4cfc7ba37eb461362657261e8ee6872ef7753a..7115561287456dbb3324f307aed4ebf27f5e2680 100644

--- a/content/child/service_worker/web_service_worker_provider_impl.cc

+++ b/content/child/service_worker/web_service_worker_provider_impl.cc

@@ -78,7 +78,7 @@ void WebServiceWorkerProviderImpl::registerServiceWorker(

void WebServiceWorkerProviderImpl::unregisterServiceWorker(

const WebURL& pattern,

- WebServiceWorkerRegistrationCallbacks* callbacks) {

+ WebServiceWorkerUnregistrationCallbacks* callbacks) {

GetDispatcher()->UnregisterServiceWorker(

provider_id_, pattern, callbacks);

}