Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 516753002: Only set fake UserGestureIndicator for tests (Closed)

Created:
6 years, 3 months ago by Zeeshan Qureshi
Modified:
6 years, 3 months ago
Project:
blink
Visibility:
Public.

Description

A recent CL to add reader mode for clank started triggering this codepath on load and was interfering with how the virtual keyboard handles programmatic focus() calls. This rogue UGI seems to have been added to get pyauto tests to pass, we should be able to only set this for tests. This is part 1 of 3, will be followed by: https://codereview.chromium.org/518583003/ BUG=408426, 407643 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181075

Patch Set 1 #

Patch Set 2 : Only set for tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -4 lines) Patch
M Source/web/WebFrame.cpp View 1 2 chunks +11 lines, -0 lines 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 1 1 chunk +1 line, -4 lines 0 comments Download
M public/web/WebFrame.h View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
Zeeshan Qureshi
zeeshanq@chromium.org changed reviewers: + abarth@chromium.org, rbyers@chromium.org
6 years, 3 months ago (2014-08-29 03:32:42 UTC) #1
Zeeshan Qureshi
Rick / Adam can you please have a look. The old code is needed to ...
6 years, 3 months ago (2014-08-29 03:32:42 UTC) #2
abarth-chromium
lgtm
6 years, 3 months ago (2014-08-29 03:33:41 UTC) #3
Zeeshan Qureshi
The CQ bit was checked by zeeshanq@chromium.org
6 years, 3 months ago (2014-08-29 03:53:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zeeshanq@chromium.org/516753002/20001
6 years, 3 months ago (2014-08-29 03:53:58 UTC) #5
Zeeshan Qureshi
Thanks Adam, that was fast!
6 years, 3 months ago (2014-08-29 03:54:18 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 181075
6 years, 3 months ago (2014-08-29 05:01:25 UTC) #7
Rick Byers
Nice, definitely a step in the right direction - thanks!
6 years, 3 months ago (2014-08-29 13:09:22 UTC) #8
dcheng
6 years, 3 months ago (2014-09-22 22:04:59 UTC) #10
Message was sent while issue was closed.
Sorry for not catching this earlier. Please move
WebFrame::executeScriptAndReturnValueForTests() to WebLocalFrameImpl--it has no
reason to belong on WebFrame, as WebRemoteFrames cannot execute script.

Powered by Google App Engine
This is Rietveld 408576698