Source/web/WebLocalFrameImpl.cpp - Issue 516753002: Only set fake UserGestureIndicator for tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebLocalFrameImpl.cpp

Issue 516753002: Only set fake UserGestureIndicator for tests (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Only set for tests Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebLocalFrameImpl.cpp

diff --git a/Source/web/WebLocalFrameImpl.cpp b/Source/web/WebLocalFrameImpl.cpp

index 99eacfb6d49300573d9602b448e966ad6beeea73..d790bca6f60068cfee8ab708c76980c445e07d97 100644

--- a/Source/web/WebLocalFrameImpl.cpp

+++ b/Source/web/WebLocalFrameImpl.cpp

@@ -754,10 +754,7 @@ v8::Handle<v8::Value> WebLocalFrameImpl::executeScriptAndReturnValue(const WebSc

{

ASSERT(frame());

- // FIXME: This fake user gesture is required to make a bunch of pyauto

- // tests pass. If this isn't needed in non-test situations, we should

- // consider removing this code and changing the tests.

- // http://code.google.com/p/chromium/issues/detail?id=86397

+ // TODO: Remove this after blink has rolled and chromium change landed. (crrev.com/516753002)

UserGestureIndicator gestureIndicator(DefinitelyProcessingNewUserGesture);

TextPosition position(OrdinalNumber::fromOneBasedInt(source.startLine), OrdinalNumber::first());

« no previous file with comments | « Source/web/WebFrame.cpp ('k') | public/web/WebFrame.h » ('j') | no next file with comments »