Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 51673005: Remove unnecessary dependency upon ScrollView from the ScrollbarTheme classes. (Closed)

Created:
7 years, 1 month ago by atreat
Modified:
7 years, 1 month ago
Reviewers:
abarth-chromium
CC:
blink-reviews, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

Remove unnecessary dependency upon ScrollView from the ScrollbarTheme classes. BUG=297477 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160960

Patch Set 1 #

Patch Set 2 : Remove redefinition of scrollOffset #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -17 lines) Patch
M Source/core/platform/ScrollView.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/platform/ScrollbarTheme.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/platform/ScrollbarTheme.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/platform/ScrollbarThemeMacCommon.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/platform/ScrollbarThemeMacCommon.mm View 1 3 chunks +2 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderScrollbarTheme.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/rendering/RenderScrollbarTheme.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
atreat
Prerequisite to moving ScrollbarTheme* to Source/platform
7 years, 1 month ago (2013-10-30 14:19:05 UTC) #1
abarth-chromium
lgtm
7 years, 1 month ago (2013-10-30 16:02:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adam.treat@samsung.com/51673005/1
7 years, 1 month ago (2013-10-30 16:03:06 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 1 month ago (2013-10-30 16:27:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adam.treat@samsung.com/51673005/160001
7 years, 1 month ago (2013-10-30 16:55:30 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-10-30 19:06:35 UTC) #6
Message was sent while issue was closed.
Change committed as 160960

Powered by Google App Engine
This is Rietveld 408576698