Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1591)

Unified Diff: Source/core/platform/ScrollbarThemeMacCommon.mm

Issue 51673005: Remove unnecessary dependency upon ScrollView from the ScrollbarTheme classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: Remove redefinition of scrollOffset Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/platform/ScrollbarThemeMacCommon.h ('k') | Source/core/rendering/RenderScrollbarTheme.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/platform/ScrollbarThemeMacCommon.mm
diff --git a/Source/core/platform/ScrollbarThemeMacCommon.mm b/Source/core/platform/ScrollbarThemeMacCommon.mm
index a5004e60954b37f15536a7f4e2c05ea4a234b532..1a27f198e9639fd242dbea6c46891166e8863cc2 100644
--- a/Source/core/platform/ScrollbarThemeMacCommon.mm
+++ b/Source/core/platform/ScrollbarThemeMacCommon.mm
@@ -180,7 +180,7 @@ void ScrollbarThemeMacCommon::paintGivenTickmarks(GraphicsContext* context, Scro
}
}
-void ScrollbarThemeMacCommon::paintOverhangBackground(ScrollView* view, GraphicsContext* context, const IntRect& horizontalOverhangRect, const IntRect& verticalOverhangRect, const IntRect& dirtyRect)
+void ScrollbarThemeMacCommon::paintOverhangBackground(GraphicsContext* context, const IntRect& horizontalOverhangRect, const IntRect& verticalOverhangRect, const IntRect& dirtyRect)
{
const bool hasHorizontalOverhang = !horizontalOverhangRect.isEmpty();
const bool hasVerticalOverhang = !verticalOverhangRect.isEmpty();
@@ -199,7 +199,7 @@ void ScrollbarThemeMacCommon::paintOverhangBackground(ScrollView* view, Graphics
context->fillRect(intersection(verticalOverhangRect, dirtyRect));
}
-void ScrollbarThemeMacCommon::paintOverhangShadows(ScrollView* view, GraphicsContext* context, const IntRect& horizontalOverhangRect, const IntRect& verticalOverhangRect, const IntRect& dirtyRect)
+void ScrollbarThemeMacCommon::paintOverhangShadows(GraphicsContext* context, const IntSize& scrollOffset, const IntRect& horizontalOverhangRect, const IntRect& verticalOverhangRect, const IntRect& dirtyRect)
{
// The extent of each shadow in pixels.
const int kShadowSize = 4;
@@ -225,7 +225,6 @@ void ScrollbarThemeMacCommon::paintOverhangShadows(ScrollView* view, GraphicsCon
GraphicsContextStateSaver stateSaver(*context);
- IntSize scrollOffset = view->scrollOffset();
FloatPoint shadowCornerOrigin;
FloatPoint shadowCornerOffset;
« no previous file with comments | « Source/core/platform/ScrollbarThemeMacCommon.h ('k') | Source/core/rendering/RenderScrollbarTheme.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698