Source/core/platform/ScrollbarTheme.h - Issue 51673005: Remove unnecessary dependency upon ScrollView from the ScrollbarTheme classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/platform/ScrollbarTheme.h

Issue 51673005: Remove unnecessary dependency upon ScrollView from the ScrollbarTheme classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: Remove redefinition of scrollOffset Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/platform/ScrollbarTheme.h

diff --git a/Source/core/platform/ScrollbarTheme.h b/Source/core/platform/ScrollbarTheme.h

index 5a9c492e1ecef6006a56ffd67e101d2e8b0e2895..7bfb6b06cdd00295c5ffa7d8c21650163179a386 100644

--- a/Source/core/platform/ScrollbarTheme.h

+++ b/Source/core/platform/ScrollbarTheme.h

@@ -77,11 +77,11 @@ public:

virtual void invalidatePart(ScrollbarThemeClient*, ScrollbarPart);

- virtual void paintScrollCorner(ScrollView*, GraphicsContext*, const IntRect& cornerRect);

+ virtual void paintScrollCorner(GraphicsContext*, const IntRect& cornerRect);

virtual void paintTickmarks(GraphicsContext*, ScrollbarThemeClient*, const IntRect&) { }

- virtual void paintOverhangBackground(ScrollView*, GraphicsContext*, const IntRect&, const IntRect&, const IntRect&);

- virtual void paintOverhangShadows(ScrollView*, GraphicsContext*, const IntRect&, const IntRect&, const IntRect&) { }

+ virtual void paintOverhangBackground(GraphicsContext*, const IntRect&, const IntRect&, const IntRect&);

+ virtual void paintOverhangShadows(GraphicsContext*, const IntSize&, const IntRect&, const IntRect&, const IntRect&) { }

virtual bool shouldCenterOnThumb(ScrollbarThemeClient*, const PlatformMouseEvent&) { return false; }

virtual bool shouldSnapBackToDragOrigin(ScrollbarThemeClient*, const PlatformMouseEvent&) { return false; }

« no previous file with comments | « Source/core/platform/ScrollView.cpp ('k') | Source/core/platform/ScrollbarTheme.cpp » ('j') | no next file with comments »