Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2404)

Unified Diff: content/renderer/pepper/ppb_var_deprecated_impl.cc

Issue 515283002: Manual fixups in PPAPI for scoped_refptr operator T* removal. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/pepper/ppb_var_deprecated_impl.cc
diff --git a/content/renderer/pepper/ppb_var_deprecated_impl.cc b/content/renderer/pepper/ppb_var_deprecated_impl.cc
index a07127781dca7286aa24c776765eb2b28204f3ea..cbd307108831f5ea5486df04315cf73bf048db65 100644
--- a/content/renderer/pepper/ppb_var_deprecated_impl.cc
+++ b/content/renderer/pepper/ppb_var_deprecated_impl.cc
@@ -41,8 +41,7 @@ class ObjectAccessor {
public:
ObjectAccessor(PP_Var var)
: object_var_(V8ObjectVar::FromPPVar(var)),
- instance_(object_var_ ? object_var_->instance() : NULL) {
- }
+ instance_(object_var_.get() ? object_var_->instance() : NULL) {}
// Check if the object is valid. If it isn't, set an exception and return
// false.
@@ -63,7 +62,7 @@ class ObjectAccessor {
PepperPluginInstanceImpl* instance() { return instance_; }
private:
- V8ObjectVar* object_var_;
+ scoped_refptr<V8ObjectVar> object_var_;
dcheng 2014/08/28 16:40:16 This was actually found by a second pass of the to
dcheng 2014/08/28 16:40:16 This was actually found by a second pass of the to
raymes 2014/08/29 01:12:45 The class is only stack allocated so this shouldn'
dcheng 2014/08/29 06:38:01 I've rebased and removed this diff.
PepperPluginInstanceImpl* instance_;
};

Powered by Google App Engine
This is Rietveld 408576698