Manual fixups in PPAPI for scoped_refptr operator T* removal.

content/renderer/pepper/ppb_var_deprecated_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/pepper/ppb_var_deprecated_impl.h"
 
 #include <limits>
 
 #include "content/renderer/pepper/host_globals.h"
 #include "content/renderer/pepper/message_channel.h"
@@ skipping 23 matching lines @@
 namespace {
 
 const char kInvalidIdentifierException[] = "Error: Invalid identifier.";
 const char kInvalidObjectException[] = "Error: Invalid object";
 const char kUnableToCallMethodException[] = "Error: Unable to call method";
 
 class ObjectAccessor {
  public:
   ObjectAccessor(PP_Var var)
       : object_var_(V8ObjectVar::FromPPVar(var)),
-        instance_(object_var_ ? object_var_->instance() : NULL) {
-  }
+        instance_(object_var_.get() ? object_var_->instance() : NULL) {}
 
   // Check if the object is valid. If it isn't, set an exception and return
   // false.
   bool IsValid(PP_Var* exception) {
     // If we already have an exception, then the call is invalid according to
     // the unittests.
     if (exception && exception->type != PP_VARTYPE_UNDEFINED)
       return false;
     if (instance_)
       return true;
     if (exception)
       *exception = ppapi::StringVar::StringToPPVar(kInvalidObjectException);
     return false;
   }
   // Lazily grab the object so that the handle is created in the current handle
   // scope.
   v8::Handle<v8::Object> GetObject() { return object_var_->GetHandle(); }
   PepperPluginInstanceImpl* instance() { return instance_; }
 
  private:
-  V8ObjectVar* object_var_;
+  scoped_refptr<V8ObjectVar> object_var_;

[dcheng, 2014/08/28 16:40:16]

This was actually found by a second pass of the tool. I'm not sure if this is
actually needed--the tool's heuristic is if a temporary scoped_refptr is being
stored into a field, the field should also be a scoped_refptr. Please let me
know if this is the right thing to do here.

[dcheng, 2014/08/28 16:40:16]

This was actually found by a second pass of the tool. I'm not sure if this is
actually needed--the tool's heuristic is if a temporary scoped_refptr is being
stored into a field, the field should also be a scoped_refptr. Please let me
know if this is the right thing to do here.

[raymes, 2014/08/29 01:12:45]

The class is only stack allocated so this shouldn't be necessary (although it
shouldn't hurt either).

Note: I reverted the change which includes this line so you might get a conflict
here :(

[dcheng, 2014/08/29 06:38:01]

I've rebased and removed this diff.

   PepperPluginInstanceImpl* instance_;
 };
 
 bool IsValidIdentifer(PP_Var identifier, PP_Var* exception) {
   if (identifier.type == PP_VARTYPE_INT32 ||
       identifier.type == PP_VARTYPE_STRING) {
     return true;
   }
   if (exception)
     *exception = ppapi::StringVar::StringToPPVar(kInvalidIdentifierException);
@@ skipping 265 matching lines @@
       &CallDeprecated,
       &Construct,
       &IsInstanceOfDeprecated,
       &CreateObjectDeprecated,
       &CreateObjectWithModuleDeprecated, };
 
   return &var_deprecated_interface;
 }
 
 }  // namespace content