content/browser/renderer_host/pepper/pepper_file_io_host.cc - Issue 515283002: Manual fixups in PPAPI for scoped_refptr operator T* removal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/pepper/pepper_file_io_host.cc

Issue 515283002: Manual fixups in PPAPI for scoped_refptr operator T* removal. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/pepper/browser_ppapi_host_impl.cc ('k') | content/renderer/pepper/ppb_var_deprecated_impl.cc » ('j') | content/renderer/pepper/ppb_var_deprecated_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/pepper/pepper_file_io_host.cc

diff --git a/content/browser/renderer_host/pepper/pepper_file_io_host.cc b/content/browser/renderer_host/pepper/pepper_file_io_host.cc

index e031eb1dad8234ebb033e961cd4c068c906bd08d..7a5e5d9ae1185650745aa176f3722cd0152b70e1 100644

--- a/content/browser/renderer_host/pepper/pepper_file_io_host.cc

+++ b/content/browser/renderer_host/pepper/pepper_file_io_host.cc

@@ -109,7 +109,9 @@ PepperFileIOHost::PepperFileIOHost(BrowserPpapiHostImpl* host,

: ResourceHost(host->GetPpapiHost(), instance, resource),

browser_ppapi_host_(host),

render_process_host_(NULL),

- file_(BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE)),

+ // TODO(dcheng): This seems sketchy. Does this not need to be ref'ed?

+ file_(BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE)

dcheng 2014/08/28 16:40:16 Do we need to ref this? Most other places seem to

raymes 2014/08/29 01:12:45 It looks like the base::FileProxy holds a ref, so

dcheng 2014/08/29 06:38:01 OK I've removed this comment then.

+ .get()),

open_flags_(0),

file_system_type_(PP_FILESYSTEMTYPE_INVALID),

max_written_offset_(0),