Issue 5149001: Merge 65840 - Provide sync integration tests with a way to set a favicon for ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5149001: Merge 65840 - Provide sync integration tests with a way to set a favicon for ... (Closed)

Created:
10 years, 1 month ago by Raghu Simha

Modified:
9 years, 7 months ago

Reviewers:
Raghu Simha

CC:
chromium-reviews, ncarter (slow), ben+cc_chromium.org, Raghu Simha, idana, Paweł Hajdan Jr., tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/branches/552d/src/

Visibility:
Public.

Merge 65840 - Provide sync integration tests with a way to set a favicon for a bookmark. Note: This is required to fix the sync tests on chrome OS. See http://code.google.com/p/chromium-os/issues/detail?id=9262 The sync integration test framework does not provide tests with a way to set a favicon for a bookmark and verify that it gets synced. This patch adds a method called SetFavicon, that allows tests to set either a generic favicon, or a variable favicon (using an index) for a bookmark. BUG=57234 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/4749003 TBR=rsimha@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66376

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+167 lines, -24 lines)			Patch
M	chrome/browser/sync/glue/bookmark_change_processor.h	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/glue/bookmark_change_processor.cc	View	3 chunks	+13 lines, -4 lines	0 comments	Download
M	chrome/test/live_sync/bookmark_model_verifier.h	View	3 chunks	+10 lines, -10 lines	0 comments	Download
M	chrome/test/live_sync/bookmark_model_verifier.cc	View	6 chunks	+80 lines, -10 lines	0 comments	Download
M	chrome/test/live_sync/live_bookmarks_sync_test.h	View	3 chunks	+35 lines, -0 lines	0 comments	Download
M	chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc	View	2 chunks	+21 lines, -0 lines	0 comments	Download

Total messages: 1 (0 generated)