Provide sync integration tests with a way to set a favicon for a bookmark.

Provide sync integration tests with a way to set a favicon for a bookmark.

The sync integration test framework does not provide tests with a way to
set a favicon for a bookmark and verify that it gets synced.

This patch adds a method called SetFavicon, that allows tests to set
either a generic favicon, or a variable favicon (using an index) for a
bookmark.

BUG=57234
TEST=sync_integration_tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65840

[Raghu Simha, 2010-11-10 00:56:15]

Tim, please review.

[Raghu Simha, 2010-11-11 01:36:25]

Tim is out of town, and may not be able to get to this for a while. Nick, could
you please review when you have the time? Thanks.

[Raghu Simha, 2010-11-11 18:39:33]

Ping.

[tim (not reviewing), 2010-11-11 19:19:18]

I can look at this now.

On Thu, Nov 11, 2010 at 6:39 PM, <rsimha@chromium.org> wrote:

> Ping.
>
>
> http://codereview.chromium.org/4749003/
>

[tim (not reviewing), 2010-11-11 19:25:34]

Please address comments, LGTM after.

http://codereview.chromium.org/4749003/diff/16002/chrome/test/live_sync/live_...
File chrome/test/live_sync/live_bookmarks_sync_test.h (right):

http://codereview.chromium.org/4749003/diff/16002/chrome/test/live_sync/live_...
chrome/test/live_sync/live_bookmarks_sync_test.h:297: // Creates a unique
favicon using index |i|.
maybe |seed| is a better name?

http://codereview.chromium.org/4749003/diff/16002/chrome/test/live_sync/two_c...
File chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc (right):

http://codereview.chromium.org/4749003/diff/16002/chrome/test/live_sync/two_c...
chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc:39: const
std::vector<unsigned char> IndexedFavicon(int i) {
is this used anywhere?

[Raghu Simha, 2010-11-11 19:39:45]

Thanks. Will commmit after the trybots go green.

http://codereview.chromium.org/4749003/diff/16002/chrome/test/live_sync/live_...
File chrome/test/live_sync/live_bookmarks_sync_test.h (right):

http://codereview.chromium.org/4749003/diff/16002/chrome/test/live_sync/live_...
chrome/test/live_sync/live_bookmarks_sync_test.h:297: // Creates a unique
favicon using index |i|.
On 2010/11/11 19:25:34, timsteele wrote:
> maybe |seed| is a better name?

Done.

http://codereview.chromium.org/4749003/diff/16002/chrome/test/live_sync/two_c...
File chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc (right):

http://codereview.chromium.org/4749003/diff/16002/chrome/test/live_sync/two_c...
chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc:39: const
std::vector<unsigned char> IndexedFavicon(int i) {
On 2010/11/11 19:25:34, timsteele wrote:
> is this used anywhere?

This will be used in new automated tests that add different favicons on
different clients. Coming up in a future patch.