Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 513313002: Fix most of the "gn check" errors in ui/* (Closed)

Created:
6 years, 3 months ago by brettw
Modified:
6 years, 3 months ago
Reviewers:
tfarina, sky
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, ben+aura_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, Ian Vollick, tfarina, tdresser+watch_chromium.org, jam, penghuang+watch_chromium.org, piman+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, sadrul, danakj+watch_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/5e4c24b9ed85b0a9bdb2cac1eab0e289ccf7fd2c Cr-Commit-Position: refs/heads/master@{#292445}

Patch Set 1 #

Patch Set 2 : Fix Android GN build #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -41 lines) Patch
M content/public/browser/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/app_list/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M ui/aura/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/base/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/ime/BUILD.gn View 1 chunk +1 line, -0 lines 1 comment Download
M ui/compositor/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/BUILD.gn View 3 chunks +17 lines, -15 lines 1 comment Download
M ui/events/ipc/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M ui/events/platform/BUILD.gn View 2 chunks +4 lines, -1 line 0 comments Download
M ui/gfx/x/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/BUILD.gn View 1 2 chunks +5 lines, -5 lines 0 comments Download
M ui/keyboard/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/keyboard/webui/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/message_center/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/platform_window/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/snapshot/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/BUILD.gn View 5 chunks +3 lines, -10 lines 0 comments Download
M ui/views/controls/webview/BUILD.gn View 3 chunks +3 lines, -1 line 0 comments Download
M ui/web_dialogs/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/wm/BUILD.gn View 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
brettw
brettw@chromium.org changed reviewers: + sky@chromium.org
6 years, 3 months ago (2014-08-28 17:35:37 UTC) #1
brettw
6 years, 3 months ago (2014-08-28 17:36:01 UTC) #2
tfarina
tfarina@chromium.org changed reviewers: + tfarina@chromium.org
6 years, 3 months ago (2014-08-28 17:54:03 UTC) #3
tfarina
lgtm I opened all files and looked at the changes. They https://codereview.chromium.org/513313002/diff/20001/ui/base/ime/BUILD.gn File ui/base/ime/BUILD.gn (right): ...
6 years, 3 months ago (2014-08-28 17:54:04 UTC) #4
sky
LGTM
6 years, 3 months ago (2014-08-28 18:00:34 UTC) #5
brettw
Committed patchset #2 (id:20001) to pending queue manually as 6ab97ef (presubmit successful).
6 years, 3 months ago (2014-08-28 19:34:23 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:01:37 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/5e4c24b9ed85b0a9bdb2cac1eab0e289ccf7fd2c
Cr-Commit-Position: refs/heads/master@{#292445}

Powered by Google App Engine
This is Rietveld 408576698