Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: ui/events/BUILD.gn

Issue 513313002: Fix most of the "gn check" errors in ui/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Android GN build Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/events/BUILD.gn
diff --git a/ui/events/BUILD.gn b/ui/events/BUILD.gn
index 21981fd65a43cb2df9d63b9bdd438cf5fded36e0..5cef145d6c1cbd16f26efc7faaa6c10d48e4b098 100644
--- a/ui/events/BUILD.gn
+++ b/ui/events/BUILD.gn
@@ -72,18 +72,6 @@ component("events_base") {
}
component("events") {
- deps = [
- ":dom4_keycode_converter",
- ":events_base",
- ":gesture_detection",
- "//base/third_party/dynamic_annotations",
- "//skia",
- "//ui/gfx",
- "//ui/gfx/geometry",
- ]
-
- defines = [ "EVENTS_IMPLEMENTATION" ]
-
sources = [
"cocoa/cocoa_event_utils.h",
"cocoa/cocoa_event_utils.mm",
@@ -114,6 +102,20 @@ component("events") {
"x/events_x.cc",
]
+ defines = [ "EVENTS_IMPLEMENTATION" ]
tfarina 2014/08/28 17:54:03 thanks for reordering this.
+
+ deps = [
+ ":dom4_keycode_converter",
+ ":events_base",
+ ":gesture_detection",
+ "//base/third_party/dynamic_annotations",
+ "//skia",
+ "//ui/gfx",
+ "//ui/gfx/geometry",
+ ]
+
+ forward_dependent_configs_from = [ ":events_base" ]
+
if (use_x11) {
configs += [
"//build/config/linux:glib",
@@ -231,13 +233,13 @@ source_set("test_support") {
]
deps = [
+ ":events",
+ ":events_base",
+ ":gesture_detection",
"//base",
"//skia",
"//ui/events/platform",
"//ui/gfx/geometry",
- ":events",
- ":events_base",
- ":gesture_detection",
]
if (is_ios) {
« ui/base/ime/BUILD.gn ('K') | « ui/compositor/BUILD.gn ('k') | ui/events/ipc/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698