Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: ui/views/BUILD.gn

Issue 513313002: Fix most of the "gn check" errors in ui/* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Android GN build Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/features.gni") 5 import("//build/config/features.gni")
6 import("//build/config/ui.gni") 6 import("//build/config/ui.gni")
7 7
8 gypi_values = exec_script( 8 gypi_values = exec_script(
9 "//build/gypi_to_gn.py", 9 "//build/gypi_to_gn.py",
10 [ rebase_path("views.gyp") ], 10 [ rebase_path("views.gyp") ],
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 ":views", 110 ":views",
111 "//base", 111 "//base",
112 "//ipc:test_support", 112 "//ipc:test_support",
113 "//skia", 113 "//skia",
114 "//testing/gtest", 114 "//testing/gtest",
115 "//ui/aura", 115 "//ui/aura",
116 "//ui/base", 116 "//ui/base",
117 "//ui/compositor", 117 "//ui/compositor",
118 "//ui/compositor:test_support", 118 "//ui/compositor:test_support",
119 "//ui/events", 119 "//ui/events",
120 "//ui/events:events_base",
120 "//ui/events/platform", 121 "//ui/events/platform",
121 "//ui/gfx", 122 "//ui/gfx",
122 "//ui/gfx/geometry", 123 "//ui/gfx/geometry",
123 "//ui/wm", 124 "//ui/wm",
124 ] 125 ]
125 126
126 if (is_chromeos) { 127 if (is_chromeos) {
127 sources -= [ 128 sources -= [
128 "test/ui_controls_factory_desktop_aurax11.cc", 129 "test/ui_controls_factory_desktop_aurax11.cc",
129 "test/ui_controls_factory_desktop_aurax11.h", 130 "test/ui_controls_factory_desktop_aurax11.h",
130 ] 131 ]
131 } 132 }
132 if (use_aura) { 133 if (use_aura) {
133 sources += gypi_values.views_test_support_aura_sources 134 sources += gypi_values.views_test_support_aura_sources
134 deps += [ "//ui/aura:test_support" ] 135 deps += [ "//ui/aura:test_support" ]
135 } 136 }
136 } 137 }
137 138
138 if (false) { # TODO(GYP) enable once this links
139
140 test("views_unittests") { 139 test("views_unittests") {
141 sources = gypi_values.views_unittests_sources 140 sources = gypi_values.views_unittests_sources
142 141
143 deps = [ 142 deps = [
144 ":test_support", 143 ":test_support",
145 ":views", 144 ":views",
146 "//base", 145 "//base",
147 "//base:i18n", 146 "//base:i18n",
148 "//base/allocator", 147 "//base/allocator",
149 "//base/test:test_support", 148 "//base/test:test_support",
150 "//skia", 149 "//skia",
151 "//testing/gtest", 150 "//testing/gtest",
152 "//third_party/icu", 151 "//third_party/icu",
153 "//ui/accessibility", 152 "//ui/accessibility",
154 "//ui/aura", 153 "//ui/aura",
155 "//ui/base", 154 "//ui/base",
156 "//ui/base:test_support", 155 "//ui/base:test_support",
157 "//ui/compositor", 156 "//ui/compositor",
158 "//ui/events", 157 "//ui/events",
159 "//ui/events:events_base", 158 "//ui/events:events_base",
160 "//ui/events/platform", 159 "//ui/events/platform",
161 "//ui/gfx", 160 "//ui/gfx",
162 "//ui/gfx/geometry", 161 "//ui/gfx/geometry",
162 "//ui/gl",
163 "//ui/wm", 163 "//ui/wm",
164 "//url", 164 "//url",
165 ] 165 ]
166 166
167 if (is_chromeos) { 167 if (is_chromeos) {
168 sources -= [ 168 sources -= [
169 "ime/input_method_bridge_unittest.cc", 169 "ime/input_method_bridge_unittest.cc",
170 "widget/desktop_aura", 170 "widget/desktop_aura",
171 ] 171 ]
172 } 172 }
(...skipping 21 matching lines...) Expand all
194 if (use_x11) { 194 if (use_x11) {
195 configs += [ 195 configs += [
196 "//build/config/linux:x11", 196 "//build/config/linux:x11",
197 "//build/config/linux:xext", 197 "//build/config/linux:xext",
198 ] 198 ]
199 deps += [ 199 deps += [
200 "//ui/events/platform/x11", 200 "//ui/events/platform/x11",
201 ] 201 ]
202 } 202 }
203 203
204 if (use_ozone) {
205 sources -= [
206 "corewm/capture_controller_unittest.cc",
207 ]
208 }
209 if (use_aura) { 204 if (use_aura) {
210 sources += gypi_values.views_unittests_aura_sources 205 sources += gypi_values.views_unittests_aura_sources
211 deps = [ "//ui/aura:test_support" ] 206 deps += [ "//ui/aura:test_support" ]
212 if (!is_chromeos) { 207 if (!is_chromeos) {
213 sources += gypi_values.views_unittests_desktop_aura_sources 208 sources += gypi_values.views_unittests_desktop_aura_sources
214 } 209 }
215 } 210 }
216 if (use_x11) { 211 if (use_x11) {
217 deps += [ "//ui/events/platform/x11" ] 212 deps += [ "//ui/events/platform/x11" ]
218 } 213 }
219 214
220 if (is_mac) { 215 if (is_mac) {
221 # views_unittests not yet compiling on Mac. http://crbug.com/378134 216 # views_unittests not yet compiling on Mac. http://crbug.com/378134
(...skipping 26 matching lines...) Expand all
248 "//testing/gtest", 243 "//testing/gtest",
249 "//ui/aura", 244 "//ui/aura",
250 "//ui/compositor", 245 "//ui/compositor",
251 "//ui/resources", 246 "//ui/resources",
252 "//ui/resources:ui_test_pak", 247 "//ui/resources:ui_test_pak",
253 "//ui/string", 248 "//ui/string",
254 "//ui/wm", 249 "//ui/wm",
255 ] 250 ]
256 } 251 }
257 } 252 }
258
259 } # if false
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698