Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: tools/perf/measurements/memory.py

Issue 511653002: Add profiling_controller that manages profilers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: s/profilers_controller/profiling_controller Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/measurements/memory.py
diff --git a/tools/perf/measurements/memory.py b/tools/perf/measurements/memory.py
index f63cf3064a14505c77f4edb99ba8b55f739bd5f8..a692633420cae26125f2bd3193393f3ae640787f 100644
--- a/tools/perf/measurements/memory.py
+++ b/tools/perf/measurements/memory.py
@@ -34,7 +34,8 @@ class Memory(page_test.PageTest):
self._memory_metric.AddResults(tab, results)
self._power_metric.AddResults(tab, results)
- if tab.browser.is_profiler_active('tcmalloc-heap'):
+ if tab.browser.platform.profiling_controller.is_profiler_active(
tonyg 2014/09/04 17:10:19 This also seems like the wrong place for this. The
nednguyen 2014/09/04 17:31:46 Yeah, we leak the profiler API through the handles
+ 'tcmalloc-heap'):
# The tcmalloc_heap_profiler dumps files at regular
# intervals (~20 secs).
# This is a minor optimization to ensure it'll dump the last file when

Powered by Google App Engine
This is Rietveld 408576698