tools/perf/measurements/loading_profile.py - Issue 511653002: Add profiling_controller that manages profilers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/loading_profile.py

Issue 511653002: Add profiling_controller that manages profilers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: s/profilers_controller/profiling_controller Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/measurements/loading_profile.py

diff --git a/tools/perf/measurements/loading_profile.py b/tools/perf/measurements/loading_profile.py

index 34425ea1eb76f2b921eab1e3542302ddbf91f8c7..6e839e67e3e680ec4f4a89e4593fa5e9318cbb36 100644

--- a/tools/perf/measurements/loading_profile.py

+++ b/tools/perf/measurements/loading_profile.py

@@ -25,9 +25,9 @@ class LoadingProfile(page_test.PageTest):

browser_type='any', options=options)

def WillNavigateToPage(self, page, tab):

- tab.browser.StartProfiling(perf_profiler.PerfProfiler.name(),

- os.path.join(tempfile.mkdtemp(),

- page.file_safe_name))

+ tab.browser.platform.profiling_controller.StartProfiling(

+ perf_profiler.PerfProfiler.name(),

+ os.path.join(tempfile.mkdtemp(), page.file_safe_name))

def ValidateAndMeasurePage(self, page, tab, results):

# In current telemetry tests, all tests wait for DocumentComplete state,

« no previous file with comments | « no previous file | tools/perf/measurements/memory.py » ('j') | tools/perf/measurements/memory.py » ('J')