Add profiling_controller that manages profilers.

tools/perf/measurements/memory.py

 # Copyright 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from metrics import memory
 from metrics import power
 from telemetry.page import page_test
 
 class Memory(page_test.PageTest):
   def __init__(self):
@@ skipping 16 matching lines @@
     # Since this is a memory benchmark, we want to sample memory histograms at
     # a high frequency.
     options.AppendExtraBrowserArgs('--memory-metrics')
 
   def ValidateAndMeasurePage(self, page, tab, results):
     self._power_metric.Stop(page, tab)
     self._memory_metric.Stop(page, tab)
     self._memory_metric.AddResults(tab, results)
     self._power_metric.AddResults(tab, results)
 
-    if tab.browser.is_profiler_active('tcmalloc-heap'):
+    if tab.browser.platform.profiling_controller.is_profiler_active(

[tonyg, 2014/09/04 17:10:19]

This also seems like the wrong place for this. The Profiler itself should be
running this. Is that possible under the API these days?

[nednguyen, 2014/09/04 17:31:46]

Yeah, we leak the profiler API through the handles in browser object. Maybe this
optimization can be moved to tcmalloc_heap_profiler.WillCloseBrowser method,
wdyt?

+        'tcmalloc-heap'):
       # The tcmalloc_heap_profiler dumps files at regular
       # intervals (~20 secs).
       # This is a minor optimization to ensure it'll dump the last file when
       # the test completes.
       tab.ExecuteJavaScript("""
         if (chrome && chrome.memoryBenchmarking) {
           chrome.memoryBenchmarking.heapProfilerDump('renderer', 'final');
           chrome.memoryBenchmarking.heapProfilerDump('browser', 'final');
         }
       """)