Convert BBH APIs to use SkRect.

Convert BBH APIs to use SkRect.

Still TODO: convert internals of SkTileGrid.cpp and SkRTree.cpp to work in floats too.

NOTREECHECKS=true

BUG=skia:1021
Committed: https://skia.googlesource.com/skia/+/533eb782edaa0b6fece6166d3001edf72ec39f11

[mtklein, 2014-08-26 22:05:22]

mtklein@google.com changed reviewers:
+ mtklein@google.com, reed@google.com, robertphillips@google.com

[reed1, 2014-08-27 13:08:26]

Does this amount of change affect perf one way or the other (I recognize the big
change is being staged) ?

lgtm

[mtklein, 2014-08-27 14:44:12]

On 2014/08/27 13:08:26, reed1 wrote:
> Does this amount of change affect perf one way or the other (I recognize the
big
> change is being staged) ?
> 
> lgtm

It's more or less no change in recording, and in the big picture definitely no
change.

As you'd expect from the code, the cvttss float -> int conversions just move
inside the BBH, so SkTileGrid::insert looks a little slower and SkRecordDraw.cpp
looks a little faster.

[mtklein, 2014-08-27 14:52:39]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-08-27 14:52:53]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/511613002/60001

[commit-bot: I haz the power, 2014-08-27 15:01:28]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  Build-Win-VS2013-x86-Debug-Trybot on tryserver.skia
(http://108.170.220.76:10117/builders/Build-Win-VS2013-x86-Debug-Trybot/builds...)

[mtklein, 2014-08-27 15:04:19]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-08-27 15:04:28]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/511613002/80001

[commit-bot: I haz the power, 2014-08-27 15:19:49]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  Build-Win-VS2013-x86-Debug-Trybot on tryserver.skia
(http://108.170.220.76:10117/builders/Build-Win-VS2013-x86-Debug-Trybot/builds...)

[commit-bot: I haz the power, 2014-08-27 15:26:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-27 15:26:48]

Try jobs failed on following builders:
  Build-Win-VS2013-x86-Debug-Trybot on tryserver.skia
(http://108.170.220.76:10117/builders/Build-Win-VS2013-x86-Debug-Trybot/builds...)

[mtklein, 2014-08-27 15:36:22]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-08-27 15:37:18]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/511613002/100001

[mtklein, 2014-08-27 15:42:25]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-08-27 15:42:32]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/511613002/120001

[commit-bot: I haz the power, 2014-08-27 16:00:20]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  Build-Win-VS2013-x86-Debug-Trybot on tryserver.skia
(http://108.170.220.76:10117/builders/Build-Win-VS2013-x86-Debug-Trybot/builds...)

[mtklein, 2014-08-27 16:03:21]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-08-27 16:04:19]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/511613002/140001

[commit-bot: I haz the power, 2014-08-27 16:14:00]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  Build-Win-VS2013-x86-Debug-Trybot on tryserver.skia
(http://108.170.220.76:10117/builders/Build-Win-VS2013-x86-Debug-Trybot/builds...)

[commit-bot: I haz the power, 2014-08-27 16:22:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-27 16:22:50]

Try jobs failed on following builders:
  Build-Win-VS2013-x86-Debug-Trybot on tryserver.skia
(http://108.170.220.76:10117/builders/Build-Win-VS2013-x86-Debug-Trybot/builds...)

[mtklein, 2014-08-27 17:26:41]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-08-27 17:27:39]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/511613002/160001

[mtklein, 2014-08-27 17:39:22]

The CQ bit was unchecked by mtklein@google.com

[mtklein, 2014-08-27 17:39:23]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-08-27 17:39:30]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/511613002/160001

[commit-bot: I haz the power, 2014-08-27 17:39:49]

Committed patchset #9 (id:160001) as 533eb782edaa0b6fece6166d3001edf72ec39f11

[mtklein, 2014-08-27 18:59:48]

A revert of this CL (patchset #9) has been created in
https://codereview.chromium.org/508873004/ by mtklein@google.com.

The reason for reverting is:  test RecordDraw_BBH:
../../tests/RecordDrawTest.cpp:140	bbh.entries[i].bounds == SkRect::MakeWH(400,
480)

Mac 10.8 Release.