Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 511503002: PRESUBMIT should only check owners for the top level include directory (Closed)

Created:
6 years, 3 months ago by rmistry
Modified:
6 years, 3 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

PRESUBMIT should only check owners for the top level include directory BUG=skia:1846 Committed: https://skia.googlesource.com/skia/+/9407eceb2784dd13c135f8f266ffbeb1ffe5fd48

Patch Set 1 : Initial upload #

Patch Set 2 : Remove testing code #

Total comments: 4

Patch Set 3 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M PRESUBMIT.py View 1 2 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
rmistry
rmistry@google.com changed reviewers: + borenet@google.com
6 years, 3 months ago (2014-08-26 18:40:26 UTC) #1
rmistry
6 years, 3 months ago (2014-08-26 18:40:26 UTC) #2
borenet
https://codereview.chromium.org/511503002/diff/20001/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/511503002/diff/20001/PRESUBMIT.py#newcode192 PRESUBMIT.py:192: for affected_git_file in input_api.AffectedFiles(): Why not just affected_file? https://codereview.chromium.org/511503002/diff/20001/PRESUBMIT.py#newcode197 ...
6 years, 3 months ago (2014-08-26 18:50:06 UTC) #3
rmistry
https://codereview.chromium.org/511503002/diff/20001/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/511503002/diff/20001/PRESUBMIT.py#newcode192 PRESUBMIT.py:192: for affected_git_file in input_api.AffectedFiles(): On 2014/08/26 18:50:06, borenet wrote: ...
6 years, 3 months ago (2014-08-26 18:59:40 UTC) #4
borenet
LGTM
6 years, 3 months ago (2014-08-26 19:00:57 UTC) #5
rmistry
The CQ bit was checked by rmistry@google.com
6 years, 3 months ago (2014-08-26 20:52:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/rmistry@google.com/511503002/40001
6 years, 3 months ago (2014-08-26 20:52:59 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-08-26 21:00:59 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (40001) as 9407eceb2784dd13c135f8f266ffbeb1ffe5fd48

Powered by Google App Engine
This is Rietveld 408576698