Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: PRESUBMIT.py

Issue 511503002: PRESUBMIT should only check owners for the top level include directory (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Addressing comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 726983027ce5b65fa935996bc4a87b149038326c..61fa2d6f92472543ff424ca08e9e01f52c5ebeeb 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -189,11 +189,12 @@ def _CheckLGTMsForPublicAPI(input_api, output_api):
"""
results = []
requires_owner_check = False
- for affected_svn_file in input_api.AffectedFiles():
- affected_file_path = affected_svn_file.AbsoluteLocalPath()
+ for affected_file in input_api.AffectedFiles():
+ affected_file_path = affected_file.LocalPath()
file_path, file_ext = os.path.splitext(affected_file_path)
- # We only care about files that end in .h and are under the include dir.
- if file_ext == '.h' and 'include' in file_path.split(os.path.sep):
+ # We only care about files that end in .h and are under the top-level
+ # include dir.
+ if file_ext == '.h' and 'include' == file_path.split(os.path.sep)[0]:
requires_owner_check = True
if not requires_owner_check:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698