PRESUBMIT should only check owners for the top level include directory

PRESUBMIT.py

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 
 """Top-level presubmit script for Skia.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
 for more details about the presubmit API built into gcl.
 """
@@ skipping 171 matching lines @@
 
 
 def _CheckLGTMsForPublicAPI(input_api, output_api):
   """Check LGTMs for public API changes.
 
   For public API files make sure there is an LGTM from the list of owners in
   PUBLIC_API_OWNERS.
   """
   results = []
   requires_owner_check = False
-  for affected_svn_file in input_api.AffectedFiles():
-    affected_file_path = affected_svn_file.AbsoluteLocalPath()
+  for affected_git_file in input_api.AffectedFiles():

[borenet, 2014/08/26 18:50:06]

Why not just affected_file?

[rmistry, 2014/08/26 18:59:39]

Not sure, it felt good to replace svn with git. Done.

+    affected_file_path = affected_git_file.LocalPath()
     file_path, file_ext = os.path.splitext(affected_file_path)
-    # We only care about files that end in .h and are under the include dir.
-    if file_ext == '.h' and 'include' in file_path.split(os.path.sep):
+    # We only care about files that end in .h and are under the top-level
+    # include dir.
+    if file_ext == '.h' and 'include' == file_path.split(os.path.sep)[0]:

[borenet, 2014/08/26 18:50:05]

os.path.dirname?

[rmistry, 2014/08/26 18:59:39]

That will not work because for paths like 'include/utils/SkWGL.h' it will return
'include/utils'

       requires_owner_check = True
 
   if not requires_owner_check:
     return results
 
   lgtm_from_owner = False
   issue = input_api.change.issue
   if issue and input_api.rietveld:
     issue_properties = input_api.rietveld.get_issue_properties(
         issue=int(issue), messages=True)
@@ skipping 41 matching lines @@
     state and an error if it is in 'Closed' state.
   """
   results = []
   results.extend(_CommonChecks(input_api, output_api))
   results.extend(
       _CheckTreeStatus(input_api, output_api, json_url=(
           SKIA_TREE_STATUS_URL + '/banner-status?format=json')))
   results.extend(_CheckLGTMsForPublicAPI(input_api, output_api))
   results.extend(_CheckOwnerIsInAuthorsFile(input_api, output_api))
   return results