Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 511283002: rename ScaledImageCache to ResourceCache (Closed)

Created:
6 years, 3 months ago by reed1
Modified:
6 years, 3 months ago
Reviewers:
bsalomon, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

rename ScaledImageCache to ResourceCache BUG=skia: Committed: https://skia.googlesource.com/skia/+/011f39aeb2b9715546eb74d9ebb71be7baf95fde

Patch Set 1 #

Patch Set 2 : update SkGraphics for the rename, add guard for chrome #

Total comments: 1

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -959 lines) Patch
M bench/ImageCacheBench.cpp View 4 chunks +6 lines, -10 lines 0 comments Download
M gyp/core.gypi View 1 chunk +1 line, -1 line 0 comments Download
M gyp/skia_for_chromium_defines.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkGraphics.h View 1 1 chunk +35 lines, -22 lines 0 comments Download
M src/core/SkBitmapCache.cpp View 7 chunks +13 lines, -14 lines 0 comments Download
M src/core/SkBitmapProcState.h View 1 2 3 chunks +0 lines, -3 lines 0 comments Download
M src/core/SkBitmapProcState.cpp View 1 2 3 chunks +3 lines, -23 lines 0 comments Download
A + src/core/SkResourceCache.h View 6 chunks +8 lines, -8 lines 0 comments Download
A + src/core/SkResourceCache.cpp View 1 22 chunks +60 lines, -62 lines 0 comments Download
D src/core/SkScaledImageCache.h View 1 chunk +0 lines, -204 lines 0 comments Download
D src/core/SkScaledImageCache.cpp View 1 chunk +0 lines, -584 lines 0 comments Download
M tests/CachedDecodingPixelRefTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/ImageCacheTest.cpp View 5 chunks +12 lines, -12 lines 0 comments Download
M tests/ScaledImageCache.cpp View 1 2 1 chunk +14 lines, -14 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
reed1
reed@google.com changed reviewers: + bsalomon@google.com, mtklein@google.com
6 years, 3 months ago (2014-08-28 15:56:56 UTC) #1
reed1
should be just a rename, plus deleting a bit of dead code (from before)
6 years, 3 months ago (2014-08-28 15:56:56 UTC) #2
reed1
The CQ bit was checked by reed@google.com
6 years, 3 months ago (2014-08-28 15:56:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/511283002/1
6 years, 3 months ago (2014-08-28 15:57:41 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 3 months ago (2014-08-28 15:57:42 UTC) #5
reed1
The CQ bit was unchecked by reed@google.com
6 years, 3 months ago (2014-08-28 15:58:07 UTC) #6
reed1
The CQ bit was checked by reed@google.com
6 years, 3 months ago (2014-08-28 16:13:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/511283002/20001
6 years, 3 months ago (2014-08-28 16:13:51 UTC) #8
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 3 months ago (2014-08-28 16:13:52 UTC) #9
mtklein
lgtm https://codereview.chromium.org/511283002/diff/20001/tests/ScaledImageCache.cpp File tests/ScaledImageCache.cpp (left): https://codereview.chromium.org/511283002/diff/20001/tests/ScaledImageCache.cpp#oldcode2 tests/ScaledImageCache.cpp:2: * Copyright 2014 Google Inc. Let's follow up ...
6 years, 3 months ago (2014-08-28 16:30:19 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 16:59:45 UTC) #11
commit-bot: I haz the power
Failed to apply patch for src/core/SkBitmapProcState.cpp: While running git apply --index -p1; error: patch failed: ...
6 years, 3 months ago (2014-08-28 16:59:46 UTC) #12
reed1
The CQ bit was checked by reed@google.com
6 years, 3 months ago (2014-08-28 20:27:05 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/511283002/40001
6 years, 3 months ago (2014-08-28 20:27:50 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-08-28 20:35:27 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 011f39aeb2b9715546eb74d9ebb71be7baf95fde

Powered by Google App Engine
This is Rietveld 408576698