tests/ReadPixelsTest.cpp - Issue 510423005: make allocPixels throw on failure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/ReadPixelsTest.cpp

Issue 510423005: make allocPixels throw on failure (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: can't use (void) to suppress the "must check return result" Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/ReadPixelsTest.cpp

diff --git a/tests/ReadPixelsTest.cpp b/tests/ReadPixelsTest.cpp

index d0bf9031f0f6fe09a36bd7933f85cd2137cf8bab..77aac1fdd50a382dce7465e226884d08aa0054e5 100644

--- a/tests/ReadPixelsTest.cpp

+++ b/tests/ReadPixelsTest.cpp

@@ -96,9 +96,7 @@ static SkPMColor convertToPMColor(SkColorType ct, SkAlphaType at, const uint32_t

static void fillCanvas(SkCanvas* canvas) {

static SkBitmap bmp;

if (bmp.isNull()) {

- SkDEBUGCODE(bool alloc =) bmp.allocN32Pixels(DEV_W, DEV_H);

- SkASSERT(alloc);

- SkAutoLockPixels alp(bmp);

+ bmp.allocN32Pixels(DEV_W, DEV_H);

intptr_t pixels = reinterpret_cast<intptr_t>(bmp.getPixels());

for (int y = 0; y < DEV_H; ++y) {

for (int x = 0; x < DEV_W; ++x) {