tests/ScaledImageCache.cpp - Issue 510423005: make allocPixels throw on failure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/ScaledImageCache.cpp

Issue 510423005: make allocPixels throw on failure (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: can't use (void) to suppress the "must check return result" Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/ScaledImageCache.cpp

diff --git a/tests/ScaledImageCache.cpp b/tests/ScaledImageCache.cpp

index b71c7443e57ad6ad7c26a7f72c8078415a9cd9c4..454f8c20423e106e3be7c5482bf54bef7c54f4d7 100644

--- a/tests/ScaledImageCache.cpp

+++ b/tests/ScaledImageCache.cpp

@@ -27,7 +27,7 @@ static bool test_scaled_image_cache_useage() {

SkAutoTUnref<SkCanvas> canvas(

SkCanvas::NewRasterN32(kCanvasSize, kCanvasSize));

SkBitmap bitmap;

- SkAssertResult(bitmap.allocN32Pixels(kBitmapSize, kBitmapSize));

+ bitmap.allocN32Pixels(kBitmapSize, kBitmapSize);

bitmap.eraseColor(0xFFFFFFFF);

SkScalar scale = SkIntToScalar(kScale);

SkScalar scaledSize = SkIntToScalar(kBitmapSize) * scale;