tests/PathOpsSkpClipTest.cpp - Issue 510423005: make allocPixels throw on failure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/PathOpsSkpClipTest.cpp

Issue 510423005: make allocPixels throw on failure (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: can't use (void) to suppress the "must check return result" Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/PathOpsSkpClipTest.cpp

diff --git a/tests/PathOpsSkpClipTest.cpp b/tests/PathOpsSkpClipTest.cpp

index d413a08a666ef8e901fc19dcea043ee85e9448f4..cdc3c1fcd910d8e2c2062e078126cb9c84b80bab 100755

--- a/tests/PathOpsSkpClipTest.cpp

+++ b/tests/PathOpsSkpClipTest.cpp

@@ -482,8 +482,7 @@ void TestResult::testOne() {

do {

int dimX = SkScalarCeilToInt(width / fScale);

int dimY = SkScalarCeilToInt(height / fScale);

- if (oldBitmap.allocN32Pixels(dimX, dimY) &&

- opBitmap.allocN32Pixels(dimX, dimY)) {

+ if (oldBitmap.tryAllocN32Pixels(dimX, dimY) && opBitmap.tryAllocN32Pixels(dimX, dimY)) {

break;

}

SkDebugf("-%d-", fScale);