tests/KtxTest.cpp - Issue 510423005: make allocPixels throw on failure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/KtxTest.cpp

Issue 510423005: make allocPixels throw on failure (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: can't use (void) to suppress the "must check return result" Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/KtxTest.cpp

diff --git a/tests/KtxTest.cpp b/tests/KtxTest.cpp

index bddd09abbfe005665546eb4522237ce2bf49e50e..32dacd5a0f433399008a34cf14e04e4ab8cbc9a7 100644

--- a/tests/KtxTest.cpp

+++ b/tests/KtxTest.cpp

@@ -28,8 +28,7 @@ DEF_TEST(KtxReadWrite, reporter) {

SkRandom rand(0x1005cbad);

SkBitmap bm8888;

- bool pixelsAllocated = bm8888.allocN32Pixels(128, 128);

- REPORTER_ASSERT(reporter, pixelsAllocated);

+ bm8888.allocN32Pixels(128, 128);

uint8_t *pixels = reinterpret_cast<uint8_t*>(bm8888.getPixels());

REPORTER_ASSERT(reporter, NULL != pixels);