Issue 510253002: Try to use URL and title of the printed frame for header and footer.

Issue 510253002: Try to use URL and title of the printed frame for header and footer. (Closed)

Created:
6 years, 3 months ago by Vitaly Buka (NO REVIEWS)

Modified:
6 years, 3 months ago

Reviewers:
Noam Samuel

CC:
chromium-reviews, android-webview-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Try to use URL and title of the printed frame for header and footer. Removed header_footer_info_ member. BUG=263710 Committed: https://crrev.com/01f88e86ba8ff7857bafca8bef5bcf3227ffa21f Cr-Commit-Position: refs/heads/master@{#292488}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -41 lines)			Patch
M	chrome/renderer/printing/print_web_view_helper.h	View		2 chunks	+7 lines, -12 lines	0 comments	Download
M	chrome/renderer/printing/print_web_view_helper.cc	View		5 chunks	+15 lines, -19 lines	0 comments	Download
M	chrome/renderer/printing/print_web_view_helper_linux.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/renderer/printing/print_web_view_helper_mac.mm	View	1 2	1 chunk	+7 lines, -4 lines	0 comments	Download
M	chrome/renderer/printing/print_web_view_helper_pdf_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/printing/print_web_view_helper_win.cc	View		1 chunk	+7 lines, -3 lines	0 comments	Download

Total messages: 6 (0 generated)

Vitaly Buka (NO REVIEWS)

vitalybuka@chromium.org changed reviewers: + noamsml@chromium.org

6 years, 3 months ago (2014-08-28 04:54:42 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/510253002/40001

6 years, 3 months ago (2014-08-28 21:14:21 UTC) #4

commit-bot: I haz the power

Committed patchset #3 (id:40001) as 08162ae38ce40dd8f6010c5f4ffbb0423920f28f

6 years, 3 months ago (2014-08-28 22:56:53 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:03:10 UTC) #6

Message was sent while issue was closed.

Patchset 3 (id:??) landed as
https://crrev.com/01f88e86ba8ff7857bafca8bef5bcf3227ffa21f
Cr-Commit-Position: refs/heads/master@{#292488}