Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4277)

Unified Diff: chrome/renderer/printing/print_web_view_helper.h

Issue 510253002: Try to use URL and title of the printed frame for header and footer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Thu Aug 28 00:07:06 PDT 2014 Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/renderer/printing/print_web_view_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/printing/print_web_view_helper.h
diff --git a/chrome/renderer/printing/print_web_view_helper.h b/chrome/renderer/printing/print_web_view_helper.h
index 67bcc73c91a9afc31d0402e312174523485a59c9..dd82d7edbf7d30e02c9aff05f05c36d6d6d4a41d 100644
--- a/chrome/renderer/printing/print_web_view_helper.h
+++ b/chrome/renderer/printing/print_web_view_helper.h
@@ -273,14 +273,13 @@ class PrintWebViewHelper
// Given the |device| and |canvas| to draw on, prints the appropriate headers
// and footers using strings from |header_footer_info| on to the canvas.
- static void PrintHeaderAndFooter(
- blink::WebCanvas* canvas,
- int page_number,
- int total_pages,
- float webkit_scale_factor,
- const PageSizeMargins& page_layout_in_points,
- const base::DictionaryValue& header_footer_info,
- const PrintMsg_Print_Params& params);
+ static void PrintHeaderAndFooter(blink::WebCanvas* canvas,
+ int page_number,
+ int total_pages,
+ const blink::WebFrame& source_frame,
+ float webkit_scale_factor,
+ const PageSizeMargins& page_layout_in_points,
+ const PrintMsg_Print_Params& params);
bool GetPrintFrame(blink::WebLocalFrame** frame);
@@ -327,10 +326,6 @@ class PrintWebViewHelper
// True, when printing from print preview.
bool print_for_preview_;
- // Strings generated by the browser process to be printed as headers and
- // footers if requested by the user.
- scoped_ptr<base::DictionaryValue> header_footer_info_;
-
// Keeps track of the state of print preview between messages.
// TODO(vitalybuka): Create PrintPreviewContext when needed and delete after
// use. Now it's interaction with various messages is confusing.
« no previous file with comments | « no previous file | chrome/renderer/printing/print_web_view_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698